Skip to content

fix(core): ensure default path is set for control flow migration #64296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aparzi wants to merge 1 commit into from
Closed

fix(core): ensure default path is set for control flow migration #64296

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions packages/core/schematics/migrations/control-flow-migration/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,17 +26,24 @@ interface Options {

export function migrate(options: Options): Rule {
return async (tree: Tree, context: SchematicContext) => {
// Apply default values from schema when not provided by the migration system
const resolvedOptions = {
path: options.path ?? './',
format: options.format ?? true,
};

let allPaths = [];
const basePath = process.cwd();
let pathToMigrate: string | undefined;
if (options.path) {
if (options.path.startsWith('..')) {

if (resolvedOptions.path) {
if (resolvedOptions.path.startsWith('..')) {
throw new SchematicsException(
'Cannot run control flow migration outside of the current project.',
);
}

pathToMigrate = normalizePath(join(basePath, options.path));
pathToMigrate = normalizePath(join(basePath, resolvedOptions.path));
if (pathToMigrate.trim() !== '') {
allPaths.push(pathToMigrate);
}
Expand Down