feat(compiler-cli): enable type checking of host bindings by default#63654
Closed
crisbeto wants to merge 1 commit into
Closed
feat(compiler-cli): enable type checking of host bindings by default#63654crisbeto wants to merge 1 commit into
crisbeto wants to merge 1 commit into
Conversation
9ff2889 to
bedfa77
Compare
Type checking of host bindings was added in v20. We're now confident enough in it to enable it by default. BREAKING CHANGE: * Previously hidden type issues in host bindings may show up in your builds. Either resolve the type issues or set `"typeCheckHostBindings": false` in the `angularCompilerOptions` section of your tsconfig.
bedfa77 to
1538467
Compare
Member
Author
crisbeto
commented
Sep 9, 2025
| hostVars: 5, | ||
| hostBindings: function FooCmp_HostBindings(rf, ctx) { | ||
| if (rf & 2) { | ||
| i0.ɵɵdomProperty("src", ctx.srcProp)("href", ctx.hrefProp)("title", ctx.titleProp); |
Member
Author
There was a problem hiding this comment.
I suspect this may indicate a pre-existing bug. Note how it didn't have a sanitizer before, but after the change it does. Will investigate it further in a follow-up.
Member
Author
There was a problem hiding this comment.
I revisited this and I think there's no bug after all. We decide whether to generate the sanitizer based on the tag name in the component's selector.
Contributor
|
This PR was merged into the repository. The changes were merged into the following branches:
|
crisbeto
added a commit
to crisbeto/angular-cli
that referenced
this pull request
Sep 10, 2025
As of angular/angular#63654 type checking of host bindings is enabled by default so we don't need the explicit flag anymore.
alan-agius4
pushed a commit
to angular/angular-cli
that referenced
this pull request
Sep 10, 2025
As of angular/angular#63654 type checking of host bindings is enabled by default so we don't need the explicit flag anymore.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type checking of host bindings was added in v20. We're now confident enough in it to enable it by default.
BREAKING CHANGE:
"typeCheckHostBindings": falsein theangularCompilerOptionssection of your tsconfig.