Skip to content

refactor(compiler-cli): remove hardcoded config for unused standalone imports rule enablement - #61622

Closed
jonathan-meier wants to merge 1 commit into
angular:mainfrom
jonathan-meier:remove_hardcoded_standalone_imports_rule_flag
Closed

refactor(compiler-cli): remove hardcoded config for unused standalone imports rule enablement#61622
jonathan-meier wants to merge 1 commit into
angular:mainfrom
jonathan-meier:remove_hardcoded_standalone_imports_rule_flag

Conversation

@jonathan-meier

@jonathan-meier jonathan-meier commented May 22, 2025

Copy link
Copy Markdown

The hardcoded config was introduced because suppressing the diagnostic via extendedDiagnostics in the TS config was unreliable in google3. This has since been fixed and the workaround is no longer needed.

Internal references: b/413098934 and cl/761262603.

Jonathan Meier
refactor(compiler-cli): remove hardcoded config for unused standalone…
d403583 
… imports rule enablement

The hardcoded config was introduced because suppressing the diagnostic
via `extendedDiagnostics` in the TS config was unreliable in google3.
This has since been fixed and the workaround is no longer needed.
@pullapprove
pullapprove Bot requested a review from crisbeto May 22, 2025 17:28
@angular-robot angular-robot Bot added the area: compiler Issues related to `ngc`, Angular's template compiler label May 22, 2025
@ngbot ngbot Bot added this to the Backlog milestone May 22, 2025
@JeanMeche JeanMeche added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release and removed action: merge The PR is ready for merge by the caretaker labels May 22, 2025
@ngbot

ngbot Bot commented May 22, 2025

Copy link
Copy Markdown

I see that you just added the action: merge label, but the following checks are still failing:
    failure status "google-internal-tests" is failing

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken main, please try rebasing to main and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label May 23, 2025
thePunderWoman pushed a commit that referenced this pull request May 26, 2025
Jonathan Meier @thePunderWoman
refactor(compiler-cli): remove hardcoded config for unused standalone…
6957808 
… imports rule enablement (#61622)

The hardcoded config was introduced because suppressing the diagnostic
via `extendedDiagnostics` in the TS config was unreliable in google3.
This has since been fixed and the workaround is no longer needed.

PR Close #61622
thePunderWoman pushed a commit that referenced this pull request May 26, 2025
Jonathan Meier @thePunderWoman
refactor(compiler-cli): remove hardcoded config for unused standalone…
556413d 
… imports rule enablement (#61622)

The hardcoded config was introduced because suppressing the diagnostic
via `extendedDiagnostics` in the TS config was unreliable in google3.
This has since been fixed and the workaround is no longer needed.

PR Close #61622
@thePunderWoman

thePunderWoman commented May 26, 2025

Copy link
Copy Markdown
Contributor

This PR was merged into the repository by commit f3dfad3.

The changes were merged into the following branches: main, 19.2.x, 20.0.x

@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented Jun 26, 2025

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Jun 26, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@crisbeto crisbeto crisbeto approved these changes
@dgp1130 dgp1130 dgp1130 approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: compiler Issues related to `ngc`, Angular's template compiler target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

5 participants

@jonathan-meier @thePunderWoman @crisbeto @dgp1130 @JeanMeche