Skip to content

refactor(devtools): switch default devtools font to material symbols#61281

Closed
milomg wants to merge 1 commit into
angular:mainfrom
milomg:material-symbols
Closed

refactor(devtools): switch default devtools font to material symbols#61281
milomg wants to merge 1 commit into
angular:mainfrom
milomg:material-symbols

Conversation

@milomg

@milomg milomg commented May 12, 2025

Copy link
Copy Markdown
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.dev application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Some of the icons were missing in the final build of the signals graph pr because of version mismatches between Google fonts and our local font copy. I updated to material-symbols-outlined to fix this error and allow us to use new icons like graph-2

Issue Number: N/A

What is the new behavior?

We now consistently use material-symbols-outlined without downloading anything from Google fonts

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@pullapprove pullapprove Bot requested review from devversion and mgechev May 12, 2025 17:42
@ngbot ngbot Bot added this to the Backlog milestone May 12, 2025
@JeanMeche JeanMeche requested review from AleksanderBodurri and dgp1130 and removed request for devversion and mgechev May 12, 2025 22:45
@pullapprove pullapprove Bot requested a review from devversion May 12, 2025 22:45
Comment thread devtools/projects/ng-devtools/src/lib/devtools.component.ts Outdated

@devversion devversion left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-for: dev-infra

Comment thread third_party/fonts.google.com/material-symbols-outlined/BUILD.bazel Outdated
@milomg milomg force-pushed the material-symbols branch 3 times, most recently from 5f6288d to 7a19c54 Compare May 15, 2025 20:50
update from Material Icons to Material Symbols, and use the local
font copy instead of Google fonts to avoid version mismatches
@milomg milomg force-pushed the material-symbols branch from 7a19c54 to ff8f34c Compare May 19, 2025 20:57
@JeanMeche JeanMeche added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels May 19, 2025
thePunderWoman pushed a commit that referenced this pull request May 20, 2025
update from Material Icons to Material Symbols, and use the local
font copy instead of Google fonts to avoid version mismatches

PR Close #61281
thePunderWoman pushed a commit that referenced this pull request May 20, 2025
update from Material Icons to Material Symbols, and use the local
font copy instead of Google fonts to avoid version mismatches

PR Close #61281
@thePunderWoman

Copy link
Copy Markdown
Contributor

This PR was merged into the repository by commit fc14ca5.

The changes were merged into the following branches: main, 19.2.x, 20.0.x

@milomg milomg deleted the material-symbols branch May 22, 2025 19:22
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Jul 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: devtools target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants