Skip to content

fix(common): support equality function in httpResource #60026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cexbrayat wants to merge 1 commit into from
Closed

fix(common): support equality function in httpResource #60026

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion packages/common/http/src/resource.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ import {
Resource,
WritableSignal,
ResourceStreamItem,
type ValueEqualityFn,
} from '@angular/core';
import {Subscription} from 'rxjs';

Expand Down Expand Up @@ -240,6 +241,7 @@ function makeHttpResourceFn<TRaw>(responseType: 'arraybuffer' | 'blob' | 'json'
() => normalizeRequest(request, responseType),
options?.defaultValue,
options?.parse as (value: unknown) => TResult,
options?.equal as ValueEqualityFn<unknown>,
) as HttpResourceRef<TResult>;
};
}
Expand Down Expand Up @@ -313,6 +315,7 @@ class HttpResourceImpl<T>
request: () => HttpRequest<T> | undefined,
defaultValue: T,
parse?: (value: unknown) => T,
equal?: ValueEqualityFn<unknown>,
) {
super(
request,
Expand Down Expand Up @@ -364,7 +367,7 @@ class HttpResourceImpl<T>
return promise;
},
defaultValue,
undefined,
equal,
injector,
);
this.client = injector.get(HttpClient);
Expand Down
17 changes: 17 additions & 0 deletions packages/common/http/test/resource_spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,6 +165,23 @@ describe('httpResource', () => {
expect(res.value()).toEqual('[1,2,3]');
});

it('should allow defining an equality function', async () => {
const backend = TestBed.inject(HttpTestingController);
const res = httpResource<number>('/data', {
injector: TestBed.inject(Injector),
equal: (_a, _b) => true,
});
TestBed.flushEffects();
const req = backend.expectOne('/data');
req.flush(1);

await TestBed.inject(ApplicationRef).whenStable();
expect(res.value()).toEqual(1);

res.value.set(5);
expect(res.value()).toBe(1); // equality blocked writes
});

it('should support text responses', async () => {
const backend = TestBed.inject(HttpTestingController);
const res = httpResource.text(
Expand Down