fix(core): Prevents race condition of cleanup for incremental hydration by thePunderWoman · Pull Request #58722 · angular/angular

thePunderWoman · 2024-11-18T19:32:27Z

When hydrating a tree of blocks, this prevents cleanup from firing more than once per tree. It also ensures the cleanup happens after hydration has finished.

fixes #58690

PR Checklist

Please check if your PR fulfills the following requirements:

The commit message follows our guidelines: https://github.com/angular/angular/blob/main/CONTRIBUTING.md#commit
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

Bugfix

Does this PR introduce a breaking change?

Yes
No

packages/core/src/defer/triggering.ts

packages/core/src/defer/registry.ts

packages/core/src/defer/triggering.ts

When hydrating a tree of blocks, this prevents cleanup from firing more than once per tree. It also ensures the cleanup happens after hydration has finished. fixes: angular#58690

…on (#58722) When hydrating a tree of blocks, this prevents cleanup from firing more than once per tree. It also ensures the cleanup happens after hydration has finished. fixes: #58690 PR Close #58722

thePunderWoman · 2024-11-21T21:39:41Z

This PR was merged into the repository by commit bd08d1d.

The changes were merged into the following branches: main, 19.0.x

angular-automatic-lock-bot · 2024-12-22T00:12:40Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

thePunderWoman added action: review The PR is still awaiting reviews from at least one requested reviewer area: core Issues related to the framework runtime target: patch This PR is targeted for the next patch release labels Nov 18, 2024

thePunderWoman requested a review from AndrewKushnir November 18, 2024 19:32

ngbot bot added this to the Backlog milestone Nov 18, 2024

angular-robot bot added area: core Issues related to the framework runtime and removed area: core Issues related to the framework runtime labels Nov 18, 2024

thePunderWoman commented Nov 18, 2024

View reviewed changes

packages/core/src/defer/triggering.ts Outdated Show resolved Hide resolved

thePunderWoman force-pushed the hydration-router branch from 6a695c3 to 2fd37a0 Compare November 18, 2024 22:08

angular-robot bot added area: core Issues related to the framework runtime and removed area: core Issues related to the framework runtime labels Nov 18, 2024

AndrewKushnir reviewed Nov 18, 2024

View reviewed changes

packages/core/src/defer/registry.ts Outdated Show resolved Hide resolved

packages/core/src/defer/triggering.ts Outdated Show resolved Hide resolved

packages/core/src/defer/triggering.ts Outdated Show resolved Hide resolved

packages/core/src/defer/triggering.ts Outdated Show resolved Hide resolved

thePunderWoman force-pushed the hydration-router branch from 2fd37a0 to 2563252 Compare November 19, 2024 14:26

angular-robot bot added area: core Issues related to the framework runtime and removed area: core Issues related to the framework runtime labels Nov 19, 2024

thePunderWoman force-pushed the hydration-router branch from 2563252 to 5cf99ea Compare November 20, 2024 15:20

angular-robot bot added area: core Issues related to the framework runtime and removed area: core Issues related to the framework runtime labels Nov 20, 2024

thePunderWoman force-pushed the hydration-router branch from 5cf99ea to 407b8f5 Compare November 20, 2024 15:22

angular-robot bot added area: core Issues related to the framework runtime and removed area: core Issues related to the framework runtime labels Nov 20, 2024

ngbot bot modified the milestone: Backlog Nov 20, 2024

thePunderWoman force-pushed the hydration-router branch from 407b8f5 to 1cfa74d Compare November 20, 2024 15:28

angular-robot bot added area: core Issues related to the framework runtime and removed area: core Issues related to the framework runtime labels Nov 20, 2024

ngbot bot modified the milestone: Backlog Nov 20, 2024

thePunderWoman force-pushed the hydration-router branch from 1cfa74d to b6bd0e8 Compare November 20, 2024 17:15

angular-robot bot removed the area: core Issues related to the framework runtime label Nov 20, 2024