Skip to content

fix(compiler): add more specific matcher for hydrate never block #58360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
brandonroberts wants to merge 3 commits into from
Closed

fix(compiler): add more specific matcher for hydrate never block #58360

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
52fa675
fix(compiler): add more specific matcher for hydrate never block
brandonroberts Oct 25, 2024
e304b2e
fixup! fix(compiler): add more specific matcher for hydrate never block
brandonroberts Oct 25, 2024
8cff6f0
fixup! fix(compiler): add more specific matcher for hydrate never block
brandonroberts Oct 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup! fix(compiler): add more specific matcher for hydrate never block
  • Loading branch information
@brandonroberts
brandonroberts committed Oct 25, 2024
commit e304b2e81efada2ba5044d89e71e047419b4d6be
2 changes: 1 addition & 1 deletion packages/compiler/test/render3/r3_template_transform_spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1420,7 +1420,7 @@ describe('R3 template transform', () => {
});

it('should report `hydrate never` used with additonal characters', () => {
expect(() => parse('@defer (hydrate nevermind) {hello}')).toThrowError(
expect(() => parse('@defer (hydrate never, and thank you) {hello}')).toThrowError(
/Unrecognized trigger/,
);
});
Expand Down