Skip to content

Output ng generate #58299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pkozlowski-opensource wants to merge 3 commits into from
Closed

Output ng generate #58299

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1673a9b
feat(core): allow running output migration on a subset of paths
pkozlowski-opensource Oct 22, 2024
b107ed6
feat(migrations): expose output as function migration
pkozlowski-opensource Oct 22, 2024
8de8c85
build(migrations): skip source map generation
alan-agius4 Oct 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
build(migrations): skip source map generation 
Remove the usage of MagicString and the generation of intermediate sourcemaps,
as sourcemaps are never included in the schematic bundles. Peparing source maps
is a CPU / memory intensive and was causing OoO errors in rollup.
  • Loading branch information
@alan-agius4 @pkozlowski-opensource
alan-agius4 authored and pkozlowski-opensource committed Oct 22, 2024
commit 8de8c85276f6c8dbc619ae1d4ee591450f961ac7
1 change: 0 additions & 1 deletion packages/core/schematics/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,5 @@ rollup_bundle(
"//packages/core/schematics/ng-generate/standalone-migration",
"@npm//@rollup/plugin-commonjs",
"@npm//@rollup/plugin-node-resolve",
"@npm//magic-string",
],
)
17 changes: 10 additions & 7 deletions packages/core/schematics/rollup.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
*/
const {nodeResolve} = require('@rollup/plugin-node-resolve');
const commonjs = require('@rollup/plugin-commonjs');
const MagicString = require('magic-string');

/** Removed license banners from input files. */
const stripBannerPlugin = {
Expand All @@ -19,15 +18,19 @@ const stripBannerPlugin = {
}

const [bannerContent] = banner;
const magicString = new MagicString(code);
const pos = code.indexOf(bannerContent);
magicString.remove(pos, pos + bannerContent.length).trimStart();
if (pos !== -1) {
const result = code.slice(0, pos) + code.slice(pos + bannerContent.length);

return {
code: result.trimStart(),
map: null,
};
}

return {
code: magicString.toString(),
map: magicString.generateMap({
hires: true,
}),
Comment thread
pkozlowski-opensource marked this conversation as resolved.
Outdated
code: code,
map: null,
};
},
};
Expand Down