Skip to content

feat(language-service): support migrating full classes to signal queries #58263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
devversion wants to merge 2 commits into from
Closed

feat(language-service): support migrating full classes to signal queries #58263

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ee14b55
feat(language-service): support migrating full classes to signal queries
devversion Oct 18, 2024
d07117e
refactor(language-service): improve name of input full class refactor…
devversion Oct 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
refactor(language-service): improve name of input full class refactor… 
…ing action

Prefixing the full class refactoring actions with `Full class` makes
them less confusing along with the individual field actions.
  • Loading branch information
@devversion
devversion committed Oct 18, 2024
commit d07117ed5eb6997a5eed2c17e8e639fd452a472b
5 changes: 3 additions & 2 deletions ...language-service/src/refactorings/convert_to_signal_input/full_class_input_refactoring.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,11 +106,12 @@ abstract class BaseConvertFullClassToSignalInputsRefactoring implements ActiveRe

export class ConvertFullClassToSignalInputsRefactoring extends BaseConvertFullClassToSignalInputsRefactoring {
static id = 'convert-full-class-to-signal-inputs-safe-mode';
static description = "Convert all class @Input's to signal inputs (safe)";
static description = "Full class: Convert all @Input's to signal inputs (safe)";
override config: MigrationConfig = {};
}
export class ConvertFullClassToSignalInputsBestEffortRefactoring extends BaseConvertFullClassToSignalInputsRefactoring {
static id = 'convert-full-class-to-signal-inputs-best-effort-mode';
static description = "Convert all class @Input's to signal inputs (forcibly, ignoring errors)";
static description =
"Full class: Convert all @Input's to signal inputs (forcibly, ignoring errors)";
override config: MigrationConfig = {bestEffortMode: true};
}