Closed
Conversation
Fixes that some changes which landed at the same time caused a compilation error in the serialized.
devversion
approved these changes
Oct 16, 2024
Fixes a test that broke because a pipe wasn't marked explicitly as `standalone: false`.
Fixes some tests that started failing, because angular#58154 made it so placeholder-only messages are extracted while angular#58176 added some tests that only contain placeholders.
37fd227 to
26d6aab
Compare
Member
|
Thanks @crisbeto |
Member
|
This PR was merged into the repository by commit 5971037. The changes were merged into the following branches: main |
devversion
pushed a commit
that referenced
this pull request
Oct 16, 2024
Fixes a test that broke because a pipe wasn't marked explicitly as `standalone: false`. PR Close #58217
devversion
pushed a commit
that referenced
this pull request
Oct 16, 2024
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Includes the following changes to fix the broken CI:
fix(compiler): handle typeof expressions in serializer
Fixes that some changes which landed at the same time caused a compilation error in the serialized.
test(compiler-cli): fix broken test
Fixes a test that broke because a pipe wasn't marked explicitly as
standalone: false.test(compiler): update failing tests
Fixes some tests that started failing, because #58154 made it so placeholder-only messages are extracted while #58176 added some tests that only contain placeholders.