Skip to content

fix(migrations): properly resolve tsconfig paths on windows #58137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
devversion wants to merge 2 commits into from
Closed

fix(migrations): properly resolve tsconfig paths on windows #58137

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8f7d758
fix(migrations): properly resolve tsconfig paths on windows
devversion Oct 9, 2024
2527d4f
refactor(migrations): improve statistic tracking of signal input migr…
devversion Oct 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions packages/core/schematics/migrations/signal-migration/src/migration.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,12 +193,24 @@ export class SignalInputMigration extends TsurgeComplexMigration<

for (const [id, input] of Object.entries(globalMetadata.knownInputs)) {
fullCompilationInputs++;
if (input.seenAsSourceInput) {
sourceInputs++;

const isConsideredSourceInput =
input.seenAsSourceInput &&
input.memberIncompatibility !== InputIncompatibilityReason.OutsideOfMigrationScope &&
input.memberIncompatibility !== InputIncompatibilityReason.SkippedViaConfigFilter;

// We won't track incompatibilities to inputs that aren't considered source inputs.
// Tracking their statistics wouldn't provide any value.
if (!isConsideredSourceInput) {
continue;
}

sourceInputs++;

if (input.memberIncompatibility !== null || input.owningClassIncompatibility !== null) {
incompatibleInputs++;
}

if (input.memberIncompatibility !== null) {
const reasonName = InputIncompatibilityReason[input.memberIncompatibility];
const key = `input-field-incompatibility-${reasonName}` as const;
Expand Down
6 changes: 3 additions & 3 deletions packages/core/schematics/utils/tsurge/helpers/angular_devkit/devkit_filesystem.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ import {
PathSegment,
PathString,
} from '@angular/compiler-cli/src/ngtsc/file_system';
import * as path from 'node:path';
import * as posixPath from 'node:path/posix';

/**
* Angular compiler file system implementation that leverages an
Expand Down Expand Up @@ -64,7 +64,7 @@ export class DevkitMigrationFilesystem implements FileSystem {
}

basename(filePath: string, extension?: string): PathSegment {
return path.basename(filePath, extension) as PathSegment;
return posixPath.basename(filePath, extension) as PathSegment;
}

normalize<T extends PathString>(path: T): T {
Expand All @@ -76,7 +76,7 @@ export class DevkitMigrationFilesystem implements FileSystem {
// In dev-kit, the NodeJS working directory should never be
// considered, so `/` is the last resort over `cwd`.
return this.normalize(
path.resolve(normalize('/'), ...normalizedPaths),
posixPath.resolve(normalize('/'), ...normalizedPaths),
) as string as AbsoluteFsPath;
}

Expand Down