Skip to content

refactor(devtools): provide user with suggestions on why their angular application is not being detected in dev mode - #57861

Closed
AleksanderBodurri wants to merge 1 commit into
angular:mainfrom
AleksanderBodurri:devtools-dev-mode-not-detected-error-message
Closed

AleksanderBodurri wants to merge 1 commit into
angular:mainfrom
AleksanderBodurri:devtools-dev-mode-not-detected-error-message

Conversation

@AleksanderBodurri

@AleksanderBodurri AleksanderBodurri commented Sep 18, 2024 •

Copy link
Copy Markdown
Member

We've been seeing some reports about Angular DevTools being unable to detect applications running in dev mode.

This commit adds more context to the error message displayed when development mode is not detected and offers some possible resolutions.

Displays common reasons why DevTools fails to detect an application running in dev mode. Links directly to angular.dev for relevant configurations.

Directs users to the Angular DevTools issue template if these resolutions don't work.

Light Mode
Screenshot 2024-09-18 at 1 19 53 AM

Dark Mode
Screenshot 2024-09-18 at 1 19 33 AM

@ngbot ngbot Bot added this to the Backlog milestone Sep 18, 2024
@angular-robot angular-robot Bot added the detected: feature PR contains a feature commit label Sep 18, 2024
@AleksanderBodurri
AleksanderBodurri force-pushed the devtools-dev-mode-not-detected-error-message branch from 1174ce2 to d432388 Compare September 18, 2024 05:43
Comment thread devtools/projects/ng-devtools/src/lib/devtools.component.scss Outdated

@mgechev mgechev left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would be very helpful!

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
If you are still experiencing problems. You can open an issue with us on our <a target="_blank" href="https://github.com/angular/angular/issues/new?assignees=&labels=&projects=&template=4-devtools.yaml">issue tracker</a>.
If you are still experiencing problems, you can open an issue with a reproduction on our <a target="_blank" href="https://github.com/angular/angular/issues/new?assignees=&labels=&projects=&template=4-devtools.yaml">issue tracker</a>.

@AleksanderBodurri
AleksanderBodurri force-pushed the devtools-dev-mode-not-detected-error-message branch from d432388 to 2ec836d Compare September 18, 2024 21:06
@AleksanderBodurri
AleksanderBodurri requested review from JeanMeche and removed request for eneajaho September 19, 2024 20:22

@JeanMeche JeanMeche left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great addition the warning message. Thank you for adding this.

@AleksanderBodurri AleksanderBodurri added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Sep 20, 2024
@pkozlowski-opensource
pkozlowski-opensource removed the request for review from mgechev September 23, 2024 09:47
…r application is not being detected in dev mode

We've been seeing some reports about Angular DevTools being unable to detect applications running in dev mode.

This commit adds more context to the error message displayed when development mode is not detected and offers some possible resolutions.

Displays 3 common reasons why DevTools fails to detect an application running in dev mode. Links directly to angular.dev for relevant configurations.

Links to the Angular DevTools issue template if none of the suggestions work.
@AleksanderBodurri
AleksanderBodurri force-pushed the devtools-dev-mode-not-detected-error-message branch from 2ec836d to 27e40fe Compare September 23, 2024 13:23
@angular-robot angular-robot Bot removed the detected: feature PR contains a feature commit label Sep 23, 2024
@AleksanderBodurri AleksanderBodurri changed the title feat(devtools): provide user with suggestions on why their angular application is not being detected in dev mode refactor(devtools): provide user with suggestions on why their angular application is not being detected in dev mode Sep 23, 2024
@pkozlowski-opensource

Copy link
Copy Markdown
Member

This PR was merged into the repository by commit 9f4063b.

The changes were merged into the following branches: main, 18.2.x

pkozlowski-opensource pushed a commit that referenced this pull request Sep 23, 2024
…r application is not being detected in dev mode (#57861)

We've been seeing some reports about Angular DevTools being unable to detect applications running in dev mode.

This commit adds more context to the error message displayed when development mode is not detected and offers some possible resolutions.

Displays 3 common reasons why DevTools fails to detect an application running in dev mode. Links directly to angular.dev for relevant configurations.

Links to the Angular DevTools issue template if none of the suggestions work.

PR Close #57861
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Oct 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: devtools target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants