fix(bundles): clean-up and re-organize UMD bundles#5697
fix(bundles): clean-up and re-organize UMD bundles#5697pkozlowski-opensource wants to merge 1 commit into
Conversation
|
This PR, when merged will leave us with publishing only one UMD bundle. This one UMD bundle should replace our current SFX bundle, as discussed in #5665 (a separate PR with removal will follow). This PR also fixes #5593 - @rkirov could you please check if the exports and their layouts are what you need for your work? As requested by @IgorMinar we don't leave bundle entry point file in our |
|
@IgorMinar this PR differs slightly from the proposal described in #5665 as it doesn't implement:
It might not be necessary as chaining looks good IMO, here is example of a simple app in ES5 with a bundle from this PR: var MyComponent = ng.core.Component({
selector: 'my-app',
template: '' +
'<h1>Hello, {{name}}!</h1>' +
' Say hello to: <input [value]="name" (input)="name = $event.target.value">' +
''
}).Class({constructor: function() {
this.name = 'World';
}});
ng.platform.browser.bootstrap(MyComponent); |
|
@vsavkin I can see that as part of 4ea5b6e you've added It is also related to #5700 where we've got some exports in angular2/angular2 that are "suspicious" and didn't make it to bundles from this PR. Could you help me with those 2 items? |
It has to be included |
There was a problem hiding this comment.
if dev and prod are the same right now, then why publish both?
let's drop prod?
There was a problem hiding this comment.
prod and dev are not the same any more. Dev got in-lined source maps, so I believe that we need both.
There was a problem hiding this comment.
you are right (as always), ignore me
|
the rest looks good. can you send a follow up PR that adds markdown file into the repo with a table describing what is contained in what bundle. thanks! |
|
we'll later move the table to the dev guide but let's just publish it under https://github.com/angular/angular/tree/master/modules/angular2/docs for now |
Fixes angular#5593 Part of angular#5665 BREAKING CHANGE: Number and content of UMD bundles have changed: - we only publish one bundle that contains: core, common, platform/browser, http, router, instrumentation and upgrade - exported names have changed and now: - core is exported as `ng.core` - common is exported as `ng.common` - platform/browser is exported as `ng.platform.browser` - http is exported as `ng.http` - router is exported as `ng.router` - instrumentation is exported as `ng.instrumentation` - upgrade is exported as `ng.upgrade`
d2168ce to
ded9b3f
Compare
|
+1 to not reexporting |
|
Lgtm |
|
Merging PR #5697 on behalf of @jelbourn to branch presubmit-jelbourn-pr-5697. |
|
Merging PR #5697 on behalf of @jelbourn to branch presubmit-jelbourn-pr-5697. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Fixes #5593
Part of #5665
BREAKING CHANGE:
Number and content of UMD bundles have changed:
ng.coreng.commonng.platform.browserng.httpng.routerng.instrumentationng.upgrade