Skip to content

fix(http): throw error if withFetch() and `withRequestsMadeViaParen… #55394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rainerhahnekamp wants to merge 1 commit into from
Closed

fix(http): throw error if withFetch() and `withRequestsMadeViaParen… #55394

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions packages/common/http/src/provider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,13 @@ export function provideHttpClient(...features: HttpFeature<HttpFeatureKind>[]):
`Configuration error: found both withXsrfConfiguration() and withNoXsrfProtection() in the same call to provideHttpClient(), which is a contradiction.` :
'');
}

if (featureKinds.has(HttpFeatureKind.RequestsMadeViaParent) && featureKinds.has(HttpFeatureKind.Fetch)) {
throw new Error(
ngDevMode ?
`Configuration error: found both withRequestsMadeViaParent() and withFetch() in the same call to provideHttpClient(), which is a contradiction.` :
'');
}
}

const providers: Provider[] = [
Expand Down
18 changes: 18 additions & 0 deletions packages/common/http/test/provider_spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -449,6 +449,24 @@ describe('provideHttpClient', () => {
expect(consoleWarnSpy.calls.count()).toBe(0);
});

it('should throw when fetch is used together with withRequestsMadeViaParent()', () => {
TestBed.resetTestingModule();

TestBed.configureTestingModule({
providers: [
provideHttpClient(),
provideHttpClientTesting(),
]
});

expect(() => createEnvironmentInjector(
[provideHttpClient(
withFetch(),
withRequestsMadeViaParent(),
)],
TestBed.inject(EnvironmentInjector))).toThrow();
});

it('should warn during SSR if fetch is not configured', () => {
resetFetchBackendWarningFlag();

Expand Down