Skip to content

cleanup: move DomAdapter from angular2/core into angular2/platform/co…#5370

Closed
vsavkin wants to merge 1 commit into
angular:masterfrom
vsavkin:move_dom_adapter_out_of_core
Closed

cleanup: move DomAdapter from angular2/core into angular2/platform/co…#5370
vsavkin wants to merge 1 commit into
angular:masterfrom
vsavkin:move_dom_adapter_out_of_core

Conversation

@vsavkin
Copy link
Copy Markdown
Contributor

@vsavkin vsavkin commented Nov 18, 2015

…mmon_dom

BREAKING CHANGE

Before

import {DomAdapter} from 'angular2/core';

After

import {DomAdapter} from 'angular2/platform/common_dom';

@vsavkin vsavkin force-pushed the move_dom_adapter_out_of_core branch from d708af3 to 1c1807d Compare November 18, 2015 22:55
@vsavkin vsavkin added the action: review The PR is still awaiting reviews from at least one requested reviewer label Nov 18, 2015
@vsavkin vsavkin added this to the beta-00 milestone Nov 18, 2015
@IgorMinar IgorMinar added pr_state: LGTM action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Nov 19, 2015
@IgorMinar IgorMinar assigned vsavkin and unassigned IgorMinar Nov 19, 2015
@vsavkin vsavkin force-pushed the move_dom_adapter_out_of_core branch 2 times, most recently from 7b483c0 to c76f026 Compare November 19, 2015 19:40
@vsavkin vsavkin added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews action: review The PR is still awaiting reviews from at least one requested reviewer labels Nov 19, 2015
@mary-poppins
Copy link
Copy Markdown

Merging PR #5370 on behalf of @alxhub to branch presubmit-alxhub-pr-5370.

@mary-poppins
Copy link
Copy Markdown

Merging PR #5370 on behalf of @alxhub to branch presubmit-alxhub-pr-5370.

@alxhub alxhub added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: merge The PR is ready for merge by the caretaker labels Nov 19, 2015
@alxhub
Copy link
Copy Markdown
Member

alxhub commented Nov 19, 2015

Seems like Travis is unhappy with the merge resolution. Just lmk when it's ready to merge again.

…mmon_dom

BREAKING CHANGE

Before

import {DomAdapter} from 'angular2/core';

After

import {DomAdapter} from 'angular2/platform/common_dom';
@vsavkin vsavkin force-pushed the move_dom_adapter_out_of_core branch from 629609e to fd47e48 Compare November 19, 2015 23:09
@vsavkin vsavkin added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Nov 19, 2015
@mary-poppins
Copy link
Copy Markdown

Merging PR #5370 on behalf of @alxhub to branch presubmit-alxhub-pr-5370.

@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants