Skip to content

refactor(EventEmitter): rename .next() to .emit()#5302

Closed
robwormald wants to merge 1 commit into
angular:masterfrom
robwormald:refactor/next-to-emit
Closed

refactor(EventEmitter): rename .next() to .emit()#5302
robwormald wants to merge 1 commit into
angular:masterfrom
robwormald:refactor/next-to-emit

Conversation

@robwormald
Copy link
Copy Markdown
Contributor

@robwormald robwormald commented Nov 16, 2015

BREAKING CHANGE

EventEmitter#next(value) is deprecated, use EventEmitter#emit(value)
instead.

Closes #4287

@robwormald robwormald force-pushed the refactor/next-to-emit branch from a6f409b to 43d34eb Compare November 16, 2015 08:00
@robwormald
Copy link
Copy Markdown
Contributor Author

robwormald commented Nov 16, 2015

Note this is marked with the big scary BREAKING CHANGE message, but has actually been deprecated, using ** @deprecated * in JS and @Deprecated('Use callEmit() instead') in Dart.

I also added emit() to the Dart EventEmitter, which aliases add(). Not sure if this is a bad thing, but seemed reasonable.

@robwormald robwormald added the action: review The PR is still awaiting reviews from at least one requested reviewer label Nov 16, 2015
@robwormald robwormald added this to the beta-00 milestone Nov 16, 2015
jeffbcross
jeffbcross reviewed Nov 17, 2015
View reviewed changes
Comment thread modules/angular2/src/facade/async.ts Outdated
Copy link
Copy Markdown
Contributor

@jeffbcross jeffbcross Nov 17, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why doesn't this enforce generic typing?

@jeffbcross
Copy link
Copy Markdown
Contributor

jeffbcross commented Nov 17, 2015

LGTM once you add the typing to emit!

@jeffbcross jeffbcross added pr_state: LGTM action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Nov 17, 2015
@jeffbcross jeffbcross assigned robwormald and unassigned jeffbcross Nov 17, 2015
@jeffbcross
Copy link
Copy Markdown
Contributor

jeffbcross commented Nov 17, 2015

@robwormald can you add the merge label and assign to Victor when you update? Also mention him in a comment to make sure he sees it.

@robwormald robwormald force-pushed the refactor/next-to-emit branch from 43d34eb to 378dbc9 Compare November 17, 2015 23:44
@robwormald robwormald added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Nov 18, 2015
@robwormald
Copy link
Copy Markdown
Contributor Author

robwormald commented Nov 18, 2015

@vsavkin ready to be mergerated, thanks

@jeffbcross jeffbcross assigned vsavkin and unassigned robwormald Nov 18, 2015
@robwormald
refactor(EventEmitter): rename .next() to .emit()
bb3bfd9 
BREAKING CHANGE:

EventEmitter#next(value) is deprecated, use EventEmitter#emit(value)
instead.

Closes angular#4287
@robwormald robwormald force-pushed the refactor/next-to-emit branch from 378dbc9 to bb3bfd9 Compare November 18, 2015 00:19
@robwormald
Copy link
Copy Markdown
Contributor Author

robwormald commented Nov 18, 2015

(just fixed the commit message, so tests are re-running, but no code changes)

@robwormald robwormald mentioned this pull request Nov 18, 2015
Closed
@mary-poppins
Copy link
Copy Markdown

mary-poppins commented Nov 18, 2015

Merging PR #5302 on behalf of @alxhub to branch presubmit-alxhub-pr-5302.

@ghost ghost mentioned this pull request Nov 18, 2015
Closed
@robwormald robwormald deleted the refactor/next-to-emit branch November 19, 2015 03:36
@timkindberg timkindberg mentioned this pull request Nov 23, 2015
Open
@ericmartinezr ericmartinezr mentioned this pull request Mar 25, 2016
Closed
This was referenced Jan 25, 2018
Merged
Merged
@angular-automatic-lock-bot
Copy link
Copy Markdown

angular-automatic-lock-bot Bot commented Sep 7, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker cla: yes

Projects

None yet

Milestone

beta.0

Development

Successfully merging this pull request may close these issues.

refactor(EventEmitter): rename "next" to "emit"

6 participants

@robwormald @jeffbcross @mary-poppins @vsavkin @alxhub @googlebot