refactor(core): Move LifeCycle functionality into ApplicationRef.#5008
Closed
alxhub wants to merge 1 commit into
Closed
refactor(core): Move LifeCycle functionality into ApplicationRef.#5008alxhub wants to merge 1 commit into
alxhub wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
There is no need for @internal on private (dixit @vsavkin)
Contributor
There was a problem hiding this comment.
We don need to have @internal otherwise it will show up in .d.ts file.
Contributor
|
I don't know the context but the changes LGTM |
|
Merging PR #5008 on behalf of @alxhub to branch presubmit-alxhub-pr-5008. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE:
Before: constructor(@Inject(LifeCycle) lifecycle) { lifecycle.tick(); }
After: constructor(@Inject(ApplicationRef) appRef) { appRef.tick(); }