refactor(compiler): don’t rely on external css parser#5006
Closed
tbosch wants to merge 1 commit into
Closed
Conversation
Contributor
Author
There was a problem hiding this comment.
How about this case:
@import 'asdf'; div {...}?
Contributor
Author
|
Test against acx demo in G3 first before merging! |
Contributor
There was a problem hiding this comment.
do we strip comment first ? (what if they contain curly brackets)
Contributor
Author
There was a problem hiding this comment.
We have the same problem with all the other regex in this file...
83a29c0 to
01b8c0a
Compare
Contributor
Author
|
Just verified against the ACX demo that this works. |
We used to use different external css parsers, depending on the `DomAdapter`. This lead to inconsistent behavior and environment specific errors. Closes angular#4993
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We used to use different external css parsers,
depending on the
DomAdapter. This lead toinconsistent behavior and environment specific errors.
Related to #4993