refactor(platform-browser): log a warning when a custom or a noop ZoneJS is used with hydration#49944
Closed
AndrewKushnir wants to merge 1 commit into
Closed
refactor(platform-browser): log a warning when a custom or a noop ZoneJS is used with hydration#49944AndrewKushnir wants to merge 1 commit into
AndrewKushnir wants to merge 1 commit into
Conversation
alan-agius4
reviewed
Apr 20, 2023
alan-agius4
reviewed
Apr 20, 2023
e99a0ae to
60e7a66
Compare
alan-agius4
approved these changes
Apr 21, 2023
Contributor
alan-agius4
left a comment
There was a problem hiding this comment.
LGTM, just some additional grammer fixes.
jessicajaniuk
approved these changes
Apr 21, 2023
…eJS is used with hydration Hydration relies on a signal from ZoneJS when it becomes stable inside an application, so that Angular can start serialization process on the server or post-hydration cleanup on the client (to remove DOM nodes that remained unclaimed). Providing a custom or a "noop" ZoneJS implementation may lead to a different timing of the "stable" event, thus triggering the serialization or the cleanup too early or too late. This is not yet a fully supported configuration. This commit adds a warning (non-blocking) for those cases.
60e7a66 to
a31279f
Compare
Contributor
Author
Contributor
Author
|
Caretaker note: presubmit is "green" (only pre-existing failing targets). |
Contributor
|
This PR was merged into the repository by commit 3bcbfec. |
dylhunn
pushed a commit
that referenced
this pull request
Apr 24, 2023
…eJS is used with hydration (#49944) Hydration relies on a signal from ZoneJS when it becomes stable inside an application, so that Angular can start serialization process on the server or post-hydration cleanup on the client (to remove DOM nodes that remained unclaimed). Providing a custom or a "noop" ZoneJS implementation may lead to a different timing of the "stable" event, thus triggering the serialization or the cleanup too early or too late. This is not yet a fully supported configuration. This commit adds a warning (non-blocking) for those cases. PR Close #49944
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hydration relies on a signal from ZoneJS when it becomes stable inside an application, so that Angular can start serialization process on the server or post-hydration cleanup on the client (to remove DOM nodes that remained unclaimed).
Providing a custom or a "noop" ZoneJS implementation may lead to a different timing of the "stable" event, thus triggering the serialization or the cleanup too early or too late. This is not yet a fully supported configuration.
This commit adds a warning (non-blocking) for those cases.
PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?