Skip to content

chore(dgeni): clean up legacy typings bundle creation#4991

Closed
alexeagle wants to merge 1 commit into
angular:masterfrom
alexeagle:cleanup_dgeni_typings
Closed

chore(dgeni): clean up legacy typings bundle creation#4991
alexeagle wants to merge 1 commit into
angular:masterfrom
alexeagle:cleanup_dgeni_typings

Conversation

@alexeagle
Copy link
Copy Markdown
Contributor

Fixes #4967

@alexeagle alexeagle force-pushed the cleanup_dgeni_typings branch from a0a6add to 0bbac3c Compare October 28, 2015 22:53
@alexeagle alexeagle added the action: review The PR is still awaiting reviews from at least one requested reviewer label Oct 28, 2015
@robwormald
Copy link
Copy Markdown
Contributor

a thousand thank yous, sir

Comment thread .bowerrc Outdated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

weird change

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I accidentally clang-format'ted the file, will revert

@IgorMinar IgorMinar assigned alexeagle and unassigned IgorMinar Oct 29, 2015
@IgorMinar IgorMinar added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Oct 29, 2015
@alexeagle alexeagle force-pushed the cleanup_dgeni_typings branch from 0bbac3c to ce8ed20 Compare October 29, 2015 20:41
@alexeagle alexeagle added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Oct 29, 2015
@mary-poppins
Copy link
Copy Markdown

Merging PR #4991 on behalf of @alexeagle to branch presubmit-alexeagle-pr-4991.

@mary-poppins mary-poppins removed the action: merge The PR is ready for merge by the caretaker label Oct 29, 2015
@alexeagle alexeagle force-pushed the cleanup_dgeni_typings branch from ce8ed20 to 759077c Compare October 29, 2015 21:15
@alexeagle alexeagle added the action: merge The PR is ready for merge by the caretaker label Oct 29, 2015
@mary-poppins
Copy link
Copy Markdown

Merging PR #4991 on behalf of @alexeagle to branch presubmit-alexeagle-pr-4991.

@mary-poppins mary-poppins removed the action: merge The PR is ready for merge by the caretaker label Oct 29, 2015
@alexeagle alexeagle closed this in 5f2eb3e Oct 29, 2015
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove deprecated dgeni dgeneration of d.ts files from gulp and CI

5 participants