Skip to content

chore(package): bump reflect-metadata version#4885

Closed
douglasduteil wants to merge 1 commit into
angular:masterfrom
douglasduteil:patch-1
Closed

chore(package): bump reflect-metadata version#4885
douglasduteil wants to merge 1 commit into
angular:masterfrom
douglasduteil:patch-1

Conversation

@douglasduteil
Copy link
Copy Markdown
Contributor

No description provided.

@IgorMinar IgorMinar self-assigned this Oct 26, 2015
@IgorMinar
Copy link
Copy Markdown
Contributor

hi there. you will also need to update the npm-shrinkwrap.json and npm-shrinkwarp.clean.json.

see the instructions here: https://github.com/angular/angular/blob/master/npm-shrinkwrap.readme.md

@IgorMinar IgorMinar added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Oct 26, 2015
@douglasduteil
Copy link
Copy Markdown
Contributor Author

Oh sorry.
I don't have a MacOs but I will try this out...

@douglasduteil
Copy link
Copy Markdown
Contributor Author

... The installation has failed dramatically multiple times
I'm proposing a new commit with what you might be expected from this PR.
Is it enough ?

@IgorMinar
Copy link
Copy Markdown
Contributor

yeah. lgtm

@IgorMinar IgorMinar added the action: merge The PR is ready for merge by the caretaker label Oct 27, 2015
@mary-poppins
Copy link
Copy Markdown

Merging PR #4885 on behalf of @IgorMinar to branch presubmit-IgorMinar-pr-4885.

@mary-poppins mary-poppins removed the action: merge The PR is ready for merge by the caretaker label Oct 27, 2015
@IgorMinar IgorMinar added pr_state: LGTM and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Oct 27, 2015
@mhevery mhevery closed this in 14f8bcc Oct 27, 2015
@douglasduteil
Copy link
Copy Markdown
Contributor Author

Great :D

@douglasduteil douglasduteil deleted the patch-1 branch October 27, 2015 14:23
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants