Skip to content

docs(NgSwitch): Sugared syntax rather than <template>#4849

Closed
kylecordes wants to merge 1 commit into
angular:masterfrom
kylecordes:improve-ng-switch-doc
Closed

docs(NgSwitch): Sugared syntax rather than <template>#4849
kylecordes wants to merge 1 commit into
angular:masterfrom
kylecordes:improve-ng-switch-doc

Conversation

@kylecordes
Copy link
Copy Markdown

I noticed that the documentation for other core directives used sugared syntax,
and updated the NgSwitch documentation to match.

@vicb
Copy link
Copy Markdown
Contributor

vicb commented Oct 21, 2015

@kylecordes I think this is covered in (pending) #4423 ?

@kylecordes
Copy link
Copy Markdown
Author

Ah, it appears so. Didn't see that one pending.

I also see that Travis failed. It appears to have nothing to do with this change, which makes me wonder if I should have based off something other than master.

@vicb
Copy link
Copy Markdown
Contributor

vicb commented Oct 21, 2015

master is fine. It seems like the error is the tests being flaky in JS.

What about closing the PR if you think the changes are covered in the other one ?

@kylecordes
Copy link
Copy Markdown
Author

I think that other pull request is definitely much more complete than my change. But it is also a much bigger change, which means it will take someone more time to review and accept. I wonder if we should leave both of them here, so that whoever has time to review and accept can pick according to how much time they are able to devote to this part of the software?

@vicb
Copy link
Copy Markdown
Contributor

vicb commented Oct 22, 2015

I'll push for the other one to be reviewed shortly.

@vicb vicb closed this Oct 22, 2015
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants