Skip to content

chore(typings): add router_spec to test.typings.npm#4651

Closed
alexeagle wants to merge 1 commit into
angular:masterfrom
alexeagle:test_for_ts1.6mods
Closed

chore(typings): add router_spec to test.typings.npm#4651
alexeagle wants to merge 1 commit into
angular:masterfrom
alexeagle:test_for_ts1.6mods

Conversation

@alexeagle
Copy link
Copy Markdown
Contributor

@alexeagle alexeagle commented Oct 10, 2015

See #4026

@alexeagle alexeagle added the action: review The PR is still awaiting reviews from at least one requested reviewer label Oct 10, 2015
@IgorMinar
Copy link
Copy Markdown
Contributor

IgorMinar commented Oct 12, 2015

Lgtm, but CI is not happy. Flake?

@IgorMinar IgorMinar added pr_state: LGTM action: merge The PR is ready for merge by the caretaker labels Oct 12, 2015
@mary-poppins
Copy link
Copy Markdown

mary-poppins commented Oct 12, 2015

Merging PR #4651 on behalf of @IgorMinar to branch presubmit-IgorMinar-pr-4651.

1 similar comment
@mary-poppins
Copy link
Copy Markdown

mary-poppins commented Oct 12, 2015

Merging PR #4651 on behalf of @IgorMinar to branch presubmit-IgorMinar-pr-4651.

@mary-poppins mary-poppins removed action: merge The PR is ready for merge by the caretaker labels Oct 12, 2015
@IgorMinar IgorMinar assigned alexeagle and unassigned IgorMinar Oct 12, 2015
@alexeagle alexeagle added this to the alpha-42 milestone Oct 12, 2015
@alexeagle
Copy link
Copy Markdown
Contributor Author

alexeagle commented Oct 12, 2015

Test failure is not a flake - I'll have to postpone it till after alpha-41 and presentation practice

@mhevery
Copy link
Copy Markdown
Contributor

mhevery commented Oct 30, 2015

@alexeagle could we get this merged?

@alexeagle alexeagle added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Oct 30, 2015
@mary-poppins
Copy link
Copy Markdown

mary-poppins commented Oct 30, 2015

Merging PR #4651 on behalf of @alexeagle to branch presubmit-alexeagle-pr-4651.

@mary-poppins mary-poppins removed the action: merge The PR is ready for merge by the caretaker label Oct 30, 2015
@alexeagle alexeagle closed this in 78875d5 Oct 30, 2015
@angular-automatic-lock-bot
Copy link
Copy Markdown

angular-automatic-lock-bot Bot commented Sep 7, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@alexeagle alexeagle

Labels

cla: yes

Projects

None yet

Milestone

beta.0

Development

Successfully merging this pull request may close these issues.

5 participants

@alexeagle @IgorMinar @mary-poppins @mhevery @googlebot