refactor(router): use ApplicationRef to provide the first bootstrapped component as ROUTER_PRIMARY_COMPONENT automatically.#4643
Conversation
There was a problem hiding this comment.
why is the Type signature commented out?
There was a problem hiding this comment.
No idea - it was done that way in the old bootstrap code, so I've carried it forward. My guess is the compiler used to not have Type.
|
Please add a breaking change notice into the commit message before/after examples that show people how to migrate. otherwise looks good to me. let's have @mhevery take a look and comment on the ApplicationRef change before merging. |
6207ed1 to
241e214
Compare
f8b8982 to
f1a119b
Compare
|
Merging PR #4643 on behalf of @IgorMinar to branch presubmit-IgorMinar-pr-4643. |
|
Merging PR #4643 on behalf of @alxhub to branch presubmit-alxhub-pr-4643. |
…d component as ROUTER_PRIMARY_COMPONENT automatically. This removes the routerBindings function as it is no longer necessary. ROUTER_BINDINGS will automatically pick the first bootstrapped component to satisfy ROUTER_PRIMARY_COMPONENT. BREAKING CHANGE: Before: bootstrap(MyComponent, [routerBindings(myComponent)]); After: bootstrap(MyComponent, [ROUTER_BINDINGS]);
|
Merging PR #4643 on behalf of @alxhub to branch presubmit-alxhub-pr-4643. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
No description provided.