Skip to content

docs(router): move examples into own file and add tests#4620

Closed
btford wants to merge 1 commit into
angular:masterfrom
btford:docs-router-api-examples-2
Closed

docs(router): move examples into own file and add tests#4620
btford wants to merge 1 commit into
angular:masterfrom
btford:docs-router-api-examples-2

Conversation

@btford
Copy link
Copy Markdown
Contributor

@btford btford commented Oct 9, 2015

This adds tests mainly for the router lifecycle hooks.

I currently have no idea what this actually looks like in the docs– I'm blocked on this error with the angular.io build:

# (in angular.io repo)

> gulp serve-and-sync
....
info:    running processor: readTypeScriptModules
error:   TypeError: Cannot read property 'forEach' of undefined
    at createExportDoc (/Users/bford/Development/angular.io/public/api-builder/typescript-package/processors/readTypeScriptModules.js:156:30)
    at /Users/bford/Development/angular.io/public/api-builder/typescript-package/processors/readTypeScriptModules.js:63:27
    at Array.forEach (native)
    at /Users/bford/Development/angular.io/public/api-builder/typescript-package/processors/readTypeScriptModules.js:56:34
    at Array.forEach (native)
    at Object.$process (/Users/bford/Development/angular.io/public/api-builder/typescript-package/processors/readTypeScriptModules.js:47:21)
    at /Users/bford/Development/angular.io/node_modules/dgeni/lib/Dgeni.js:202:28
    at _fulfilled (/Users/bford/Development/angular.io/node_modules/dgeni/node_modules/q/q.js:798:54)
    at self.promiseDispatch.done (/Users/bford/Development/angular.io/node_modules/dgeni/node_modules/q/q.js:827:30)
    at Promise.promise.promiseDispatch (/Users/bford/Development/angular.io/node_modules/dgeni/node_modules/q/q.js:760:13)
error:   Error processing docs:
[18:51:01] 'build-api-docs' errored after 2.99 s
[18:51:01] TypeError: Cannot read property 'forEach' of undefined
    at createExportDoc (/Users/bford/Development/angular.io/public/api-builder/typescript-package/processors/readTypeScriptModules.js:156:30)
    at /Users/bford/Development/angular.io/public/api-builder/typescript-package/processors/readTypeScriptModules.js:63:27
    at Array.forEach (native)
    at /Users/bford/Development/angular.io/public/api-builder/typescript-package/processors/readTypeScriptModules.js:56:34
    at Array.forEach (native)
    at Object.$process (/Users/bford/Development/angular.io/public/api-builder/typescript-package/processors/readTypeScriptModules.js:47:21)
    at /Users/bford/Development/angular.io/node_modules/dgeni/lib/Dgeni.js:202:28
    at _fulfilled (/Users/bford/Development/angular.io/node_modules/dgeni/node_modules/q/q.js:798:54)
    at self.promiseDispatch.done (/Users/bford/Development/angular.io/node_modules/dgeni/node_modules/q/q.js:827:30)
    at Promise.promise.promiseDispatch (/Users/bford/Development/angular.io/node_modules/dgeni/node_modules/q/q.js:760:13)

@btford btford closed this in 4fe1792 Oct 27, 2015
@angular-automatic-lock-bot
Copy link
Copy Markdown

angular-automatic-lock-bot Bot commented Sep 7, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@btford @googlebot