Skip to content

docs(NgClass): update docs, add example#4520

Closed
pkozlowski-opensource wants to merge 1 commit into
angular:masterfrom
pkozlowski-opensource:docs_ng_class
Closed

docs(NgClass): update docs, add example#4520
pkozlowski-opensource wants to merge 1 commit into
angular:masterfrom
pkozlowski-opensource:docs_ng_class

Conversation

@pkozlowski-opensource
Copy link
Copy Markdown
Member

No description provided.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add plunker link

@IgorMinar IgorMinar added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Oct 5, 2015
@IgorMinar IgorMinar added this to the alpha-39 milestone Oct 5, 2015
@naomiblack naomiblack modified the milestones: alpha-39, alpha-40 Oct 6, 2015
@IgorMinar
Copy link
Copy Markdown
Contributor

@pkozlowski-opensource can you please clean this up and merge?

@pkozlowski-opensource
Copy link
Copy Markdown
Member Author

@IgorMinar was trying to do so today but was hitting pbs with inlined styles in alpha.39. Need to investigate more to confirm that this is a bug. But yeh, I didn't forget this one, just wasn't able to make the plunk work with inline styles. Will continue tomorrow.

@pkozlowski-opensource
Copy link
Copy Markdown
Member Author

Moving to alpha-41 as I won't have time to finish this one today

@pkozlowski-opensource pkozlowski-opensource added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Oct 10, 2015
@mary-poppins
Copy link
Copy Markdown

Merging PR #4520 on behalf of @pkozlowski-opensource to branch presubmit-pkozlowski-opensource-pr-4520.

@mary-poppins mary-poppins removed the action: merge The PR is ready for merge by the caretaker label Oct 10, 2015
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants