Skip to content

docs(forms): Document the rest of the forms module.#4437

Closed
alxhub wants to merge 1 commit into
angular:masterfrom
alxhub:forms-docs-3
Closed

docs(forms): Document the rest of the forms module.#4437
alxhub wants to merge 1 commit into
angular:masterfrom
alxhub:forms-docs-3

Conversation

@alxhub
Copy link
Copy Markdown
Member

@alxhub alxhub commented Sep 30, 2015

No description provided.

@alxhub alxhub added the action: review The PR is still awaiting reviews from at least one requested reviewer label Sep 30, 2015
@alxhub alxhub assigned vsavkin and unassigned jeffbcross Oct 5, 2015
vsavkin
vsavkin reviewed Oct 26, 2015
View reviewed changes
Comment thread modules/angular2/src/core/forms/directives/ng_control_group.ts Outdated
Copy link
Copy Markdown
Contributor

@vsavkin vsavkin Oct 26, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cg should never be null

@vsavkin vsavkin added pr_state: LGTM action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Oct 26, 2015
@vsavkin vsavkin assigned alxhub and unassigned vsavkin Oct 26, 2015
@alxhub alxhub force-pushed the forms-docs-3 branch 3 times, most recently from fb41538 to 327742b Compare October 29, 2015 20:28
@mary-poppins
Copy link
Copy Markdown

mary-poppins commented Oct 29, 2015

Merging PR #4437 on behalf of @alxhub to branch presubmit-alxhub-pr-4437.

@alxhub alxhub added the action: merge The PR is ready for merge by the caretaker label Oct 29, 2015
@mary-poppins mary-poppins removed the action: merge The PR is ready for merge by the caretaker label Oct 29, 2015
@alxhub alxhub closed this in ef23fe6 Oct 29, 2015
@angular-automatic-lock-bot
Copy link
Copy Markdown

angular-automatic-lock-bot Bot commented Sep 7, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@alxhub alxhub

Labels

action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@alxhub @mary-poppins @vsavkin @jeffbcross @googlebot