Skip to content

docs: edit TOOLS_DART.md#4422

Closed
kwalrath wants to merge 2 commits into
angular:masterfrom
kwalrath:kwalrath-tools-dart-2
Closed

docs: edit TOOLS_DART.md#4422
kwalrath wants to merge 2 commits into
angular:masterfrom
kwalrath:kwalrath-tools-dart-2

Conversation

@kwalrath

Copy link
Copy Markdown
Contributor

Add more info about reflector and the profiler, and copyedit other sections.

@kwalrath

Copy link
Copy Markdown
Contributor Author

@yjbanov how does this look?

@kwalrath kwalrath changed the title docs: edit DART_TOOLS.md docs: edit TOOLS_DART.md Sep 30, 2015
Comment thread TOOLS_DART.md Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrap @component and @Injectable in back-ticks so it looks like @Component

Add more info about reflector, and copyedit other sections.
@kwalrath

Copy link
Copy Markdown
Contributor Author

PTAL. I removed the talk about the dart2js transformer and emphasized Dartium. If we want to strongly recommend that they use Dartium instead of another browser, then I can completely remove the minification stuff. Although... I think I ran into it even in Dartium because I happened to be using dart_to_js_script_rewriter, a transformer (included in the web-simple Stagehand template) that changes the HTML file's .dart reference to be a .dart.js reference.

@yjbanov

yjbanov commented Oct 1, 2015

Copy link
Copy Markdown
Contributor

The normal pub serve workflow should work out-of-the-box both in Dartium and (without minification) in other browsers. Later, when DDC lands, we can look at other options. LGTM.

@kwalrath

kwalrath commented Oct 1, 2015

Copy link
Copy Markdown
Contributor Author

So... Do you want to accept it as-is, or do you want me to remove the unminification details?

@mhevery mhevery added the action: merge The PR is ready for merge by the caretaker label Oct 5, 2015
@mary-poppins

Copy link
Copy Markdown

Merging PR #4422 on behalf of @mhevery to branch presubmit-mhevery-pr-4422.

@mary-poppins mary-poppins removed the action: merge The PR is ready for merge by the caretaker label Oct 5, 2015
@mhevery mhevery added pr_state: LGTM action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Oct 27, 2015
@mhevery mhevery closed this in cd219b9 Oct 27, 2015
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews cla: yes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants