Yeh, if the trick doesn't do anything, we should remove it. BTW, did you check if Sauce Labs didn't fix it on their end? If I recall well there was a ticket on their side to have an option to update badges only when a certain flag is present or something.

Thinking about it some more: maybe it is better to show "unknown" state for PRs? The thing is that if a PR breaks tests it will be displayed on the ng landing page and it would be looking bad.

So actually my vote would go to removing those badges till we can make them work (update) only on master builds.

From Sauce Labs documentation, it is not possible.

Next proposal is to use the dedicated 'angular2-ci' account only for commits on master, otherwise use the default one. This way the badge will show the state of master only. PTAL

was this merged already? I saw a similar change in master already

looks like this landed as e1853b3

did you bypass the presubmit queue?

This PR fixes the badge which was introduced in e1853b3 from #4400.
The first commit went through presubmit queue.

I see. thanks for the explanation.

Merging PR #4412 on behalf of @IgorMinar to branch presubmit-IgorMinar-pr-4412.

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}