migrate ngOutlet to typescript#4386
Conversation
There was a problem hiding this comment.
Wouldn't it be preferable to create this class once (outside of the link function), instead of recreating it ?
There was a problem hiding this comment.
It would, but since we need a lot of things from the closure (scope, element, transclude, etc.) I prefer not having to pass all of those in the constructor
There was a problem hiding this comment.
I prefer not having to pass all of those in the constructor
Any particular reason ?
Besides the perf impact of creating a new function in each outletLink fn execution, it is also hard to spot what outer dependencies the class has.
Since it's a "non-public" class (i.e. we don't care about breaking the API if needed), why not pass the arguments explicitly ?
|
LGTM, merging. |
|
Merging PR #4386 on behalf of @btford to branch presubmit-btford-pr-4386. |
|
Hm, this never got merged. Let me rebase and try again. |
|
Pushed to presubmit again after some rebasing: https://travis-ci.org/angular/angular/builds/84430878 👍 |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
@btford plz review