Skip to content

docs(examples): add empty examples directory for api docs examples#4341

Closed
IgorMinar wants to merge 1 commit into
angular:masterfrom
IgorMinar:docs-examples
Closed

docs(examples): add empty examples directory for api docs examples#4341
IgorMinar wants to merge 1 commit into
angular:masterfrom
IgorMinar:docs-examples

Conversation

@IgorMinar
Copy link
Copy Markdown
Contributor

@IgorMinar IgorMinar commented Sep 23, 2015

This is a place for api docs examples hand written in an idiomatic way.

@IgorMinar
docs(examples): add empty examples directory for api docs examples
801e251 
This is a place for api docs examples hand written in an idiomatic way.
@IgorMinar IgorMinar mentioned this pull request Sep 23, 2015
Closed
@IgorMinar
Copy link
Copy Markdown
Contributor Author

IgorMinar commented Sep 23, 2015

cc: @btford @naomiblack

@IgorMinar IgorMinar added the action: review The PR is still awaiting reviews from at least one requested reviewer label Sep 23, 2015
@btford
Copy link
Copy Markdown
Contributor

btford commented Sep 23, 2015

LGTM

@btford btford assigned btford and unassigned rkirov Sep 23, 2015
@mary-poppins
Copy link
Copy Markdown

mary-poppins commented Sep 23, 2015

Merging PR #4341 on behalf of @btford to branch presubmit-btford-pr-4341.

@btford btford added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Sep 23, 2015
@mary-poppins mary-poppins removed the action: merge The PR is ready for merge by the caretaker label Sep 23, 2015
@rkirov
Copy link
Copy Markdown
Contributor

rkirov commented Sep 23, 2015

Why not rename modules/examples in the same PR to avoid confusion in the meantime.

Why modules/angular2/examples instead of modules/examples? Being inside angular2 means we would publish examples to npm as part of publishing angular2 (which might be desirable).

Also a reminder for the example writers to use the bundles unlike our current examples.

@btford
Copy link
Copy Markdown
Contributor

btford commented Sep 23, 2015

Being inside angular2 means we would publish examples to npm as part of publishing angular2

I assumed that was the intent

@IgorMinar IgorMinar closed this in ea15d66 Sep 23, 2015
robwormald pushed a commit to robwormald/angular that referenced this pull request Sep 25, 2015
@IgorMinar @robwormald
docs(examples): add empty examples directory for api docs examples
0f2e816 
This is a place for api docs examples hand written in an idiomatic way.

Closes angular#4341
@angular-automatic-lock-bot
Copy link
Copy Markdown

angular-automatic-lock-bot Bot commented Sep 7, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@btford btford

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@IgorMinar @btford @mary-poppins @rkirov @googlebot