Skip to content

build(travis): block travis while we are shutting down the tunnel#4335

Closed
IgorMinar wants to merge 1 commit into
angular:masterfrom
IgorMinar:sauce-connect-teardown-wait
Closed

build(travis): block travis while we are shutting down the tunnel#4335
IgorMinar wants to merge 1 commit into
angular:masterfrom
IgorMinar:sauce-connect-teardown-wait

Conversation

@IgorMinar

Copy link
Copy Markdown
Contributor

This is to prevent Travis from prematurely shut down the VM while we are still waiting for the sauce connect client
to tear down the tunnel.

@IgorMinar

Copy link
Copy Markdown
Contributor Author

@alexeagle this is a follow up to #4329 which I had to push last night in order to prevent sauce tunnel leaks

@IgorMinar IgorMinar added area: build & ci Related the build and CI infrastructure of the project action: review The PR is still awaiting reviews from at least one requested reviewer labels Sep 23, 2015
Comment thread scripts/sauce/sauce_connect_teardown.sh Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bee -> been

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yellow jacket!

thanks

@IgorMinar

Copy link
Copy Markdown
Contributor Author

It won't hang forever because Travis will kill the build if it's running too long.

I've played with sc quite a bit and have never seen it fail closing the tunnel. If that happens, I'd rather know about it so that we can fix it so that we don't leak tunnels. So I'd prefer to keep this as is.

This is to prevent Travis from prematurely shut down the VM while we are still waiting for the sauce connect client
to tear down the tunnel.
@IgorMinar IgorMinar force-pushed the sauce-connect-teardown-wait branch from 027f056 to 9e4b622 Compare September 23, 2015 17:57
@IgorMinar IgorMinar added the action: merge The PR is ready for merge by the caretaker label Sep 23, 2015
@mary-poppins mary-poppins removed the action: merge The PR is ready for merge by the caretaker label Sep 23, 2015
@mary-poppins

Copy link
Copy Markdown

Merging PR #4335 on behalf of @IgorMinar to branch presubmit-IgorMinar-pr-4335.

@IgorMinar IgorMinar closed this in 4d4d20e Sep 23, 2015
robwormald pushed a commit to robwormald/angular that referenced this pull request Sep 25, 2015
This is to prevent Travis from prematurely shut down the VM while we are still waiting for the sauce connect client
to tear down the tunnel.

Closes angular#4335
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: review The PR is still awaiting reviews from at least one requested reviewer area: build & ci Related the build and CI infrastructure of the project cla: yes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants