docs(router): improve docs for RouteDefinition classes#4299
Conversation
|
idk what the failure here means: https://travis-ci.org/angular/angular/jobs/81480392#L1454-L1465 |
|
that's an internal error. the real problem is here: https://travis-ci.org/angular/angular/jobs/81480392#L1314 |
|
@IgorMinar I'm not sure what to do about this error– is there a problem with my code? Do I need to debug e2e locally? Or is it a flake? |
590db53 to
1102d86
Compare
|
@btford Have you noticed all pull requests are receiving that same error? https://travis-ci.org/angular/angular/pull_requests |
|
@danielrasmuson – yep, still investigating the cause. |
1102d86 to
de78f02
Compare
There was a problem hiding this comment.
Same here routerBindings -> ROUTER_BINDINGS ?
There was a problem hiding this comment.
Ah never mind, seen later that routerBindings is a helper function. I find it rather confusing at first tho
There was a problem hiding this comment.
Agree, I think we should only export the helper TBH.
There was a problem hiding this comment.
Are there use cases (maybe in tests) where we are really just interested in ROUTER_BINDINGS?
|
@btford very good work! I left some comments here and there. Otherwise LGTM |
de78f02 to
f5d9bd3
Compare
No description provided.