Skip to content

Compiler/View API documentation#4268

Closed
IgorMinar wants to merge 4 commits into
angular:masterfrom
IgorMinar:docs-element-ref
Closed

Compiler/View API documentation#4268
IgorMinar wants to merge 4 commits into
angular:masterfrom
IgorMinar:docs-element-ref

Conversation

@IgorMinar
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing }. at the end.

@IgorMinar IgorMinar force-pushed the docs-element-ref branch 2 times, most recently from 5692180 to 2b3b72a Compare September 25, 2015 13:46
@IgorMinar IgorMinar changed the title WIP: Compiler/View documentation Compiler/View API documentation Sep 25, 2015
@IgorMinar
Copy link
Copy Markdown
Contributor Author

@tbosch can you please review. This PR doesn't contain most of the property/method/local var renames that we discussed.

@IgorMinar
Copy link
Copy Markdown
Contributor Author

and I need to rebase it on master, but you can review the docs even before that

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"View in "global view" is not an Angular view. Maybe find a better word?

@tbosch tbosch added pr_state: LGTM action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Sep 25, 2015
@tbosch tbosch assigned IgorMinar and unassigned tbosch Sep 25, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews cla: yes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants