Skip to content

docs(typings): don't emit @private members during the d.ts generation#4264

Closed
IgorMinar wants to merge 1 commit into
angular:masterfrom
IgorMinar:docs-hide-at-private
Closed

docs(typings): don't emit @private members during the d.ts generation#4264
IgorMinar wants to merge 1 commit into
angular:masterfrom
IgorMinar:docs-hide-at-private

Conversation

@IgorMinar
Copy link
Copy Markdown
Contributor

Some of our class/interface members are "package private". Typescript doesn't have this concept, so we need to hide them
via the @private doc annotation.

Closes #4262

Some of our class/interface members are "package private". Typescript doesn't have this concept, so we need to hide them
via the @Private doc annotation.

Closes angular#4262
@IgorMinar IgorMinar added the action: review The PR is still awaiting reviews from at least one requested reviewer label Sep 18, 2015
@alexeagle alexeagle added pr_state: LGTM and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Sep 18, 2015
@IgorMinar IgorMinar added the action: merge The PR is ready for merge by the caretaker label Sep 18, 2015
@mary-poppins
Copy link
Copy Markdown

Merging PR #4264 on behalf of @IgorMinar to branch presubmit-IgorMinar-pr-4264.

@mary-poppins mary-poppins removed the action: merge The PR is ready for merge by the caretaker label Sep 18, 2015
@IgorMinar IgorMinar closed this in dd9b3b4 Sep 18, 2015
robwormald pushed a commit to robwormald/angular that referenced this pull request Sep 25, 2015
Some of our class/interface members are "package private". Typescript doesn't have this concept, so we need to hide them
via the @Private doc annotation.

Closes angular#4262

Closes angular#4264
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Class/Interface members marked as @private should not be present in the d.ts files

4 participants