Skip to content

docs(http): add docs and examples for HTTP_BINDINGS#4238

Closed
jeffbcross wants to merge 4 commits into
angular:masterfrom
jeffbcross:docs-http-bindings
Closed

docs(http): add docs and examples for HTTP_BINDINGS#4238
jeffbcross wants to merge 4 commits into
angular:masterfrom
jeffbcross:docs-http-bindings

Conversation

@jeffbcross
Copy link
Copy Markdown
Contributor

No description provided.

@jeffbcross jeffbcross added comp: docs action: review The PR is still awaiting reviews from at least one requested reviewer labels Sep 17, 2015
Comment thread modules/angular2/http.ts Outdated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldn't we also just bind(XHRBackend).toClass(MockBackend) here?

Comment thread modules/angular2/http.ts
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't the Object[] form to be preferred (over Array<Object>) ?

@vsavkin vsavkin assigned jeffbcross and unassigned vsavkin Sep 18, 2015
@vsavkin vsavkin removed the action: review The PR is still awaiting reviews from at least one requested reviewer label Sep 18, 2015
@jeffbcross jeffbcross force-pushed the docs-http-bindings branch 2 times, most recently from c11de31 to 768769a Compare September 18, 2015 19:10
@mary-poppins
Copy link
Copy Markdown

Merging PR #4238 on behalf of @jeffbcross to branch presubmit-jeffbcross-pr-4238.

@jeffbcross jeffbcross added the action: merge The PR is ready for merge by the caretaker label Sep 18, 2015
@mary-poppins mary-poppins removed the action: merge The PR is ready for merge by the caretaker label Sep 18, 2015
@jeffbcross jeffbcross added the action: merge The PR is ready for merge by the caretaker label Sep 21, 2015
@mary-poppins mary-poppins removed the action: merge The PR is ready for merge by the caretaker label Sep 21, 2015
@mary-poppins
Copy link
Copy Markdown

Merging PR #4238 on behalf of @jeffbcross to branch presubmit-jeffbcross-pr-4238.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants