Skip to content

feat(compiler): add change detector generation#4057

Closed
tbosch wants to merge 1 commit into
angular:masterfrom
tbosch:change_compiler
Closed

feat(compiler): add change detector generation#4057
tbosch wants to merge 1 commit into
angular:masterfrom
tbosch:change_compiler

Conversation

@tbosch
Copy link
Copy Markdown
Contributor

@tbosch tbosch commented Sep 8, 2015

Runtime and Codegen.

Part of #3605

@tbosch tbosch added the action: review The PR is still awaiting reviews from at least one requested reviewer label Sep 8, 2015
@tbosch tbosch force-pushed the change_compiler branch 3 times, most recently from 758e221 to 6ab3b0d Compare September 9, 2015 15:52
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

first create ProtoChangeDetector and use it for all .instantiate methods

@tbosch tbosch added pr_state: LGTM action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Sep 9, 2015
@tbosch tbosch assigned tbosch and unassigned vsavkin Sep 9, 2015
@tbosch
Copy link
Copy Markdown
Contributor Author

tbosch commented Sep 9, 2015

Reviewed with @vsavkin in person

@tbosch tbosch force-pushed the change_compiler branch 3 times, most recently from 59607fd to a7833c2 Compare September 9, 2015 22:01
@tbosch tbosch added the action: merge The PR is ready for merge by the caretaker label Sep 9, 2015
@mary-poppins
Copy link
Copy Markdown

Merging PR #4057 on behalf of @tbosch to branch presubmit-tbosch-pr-4057.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants