Skip to content

Revert "chore(benchmarks): disable broken benchmarks" #3764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yjbanov wants to merge 1 commit into from
Closed

Revert "chore(benchmarks): disable broken benchmarks" #3764

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions protractor-dart2js.conf.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,8 @@ config.exclude.push(
// TODO: remove this line when largetable dart has been added
'dist/js/cjs/benchmarks_external/e2e_test/largetable_perf.js',
'dist/js/cjs/benchmarks_external/e2e_test/polymer_tree_perf.js',
'dist/js/cjs/benchmarks_external/e2e_test/react_tree_perf.js',
// TODO: remove once https://github.com/angular/angular/issues/3757 is resolved
'dist/js/cjs/benchmarks_external/e2e_test/compiler_perf.js',
'dist/js/cjs/benchmarks_external/e2e_test/naive_infinite_scroll.js',
'dist/js/cjs/benchmarks_external/e2e_test/tree.js'
'dist/js/cjs/benchmarks_external/e2e_test/react_tree_perf.js'

);

data.createBenchpressRunner({ lang: 'dart' });
Expand Down
4 changes: 0 additions & 4 deletions protractor-js.conf.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,6 @@ config.baseUrl = 'http://localhost:8001/';
// TODO: remove exclusion when JS verison of scrolling benchmark is available
config.exclude.push('dist/js/cjs/benchmarks_external/e2e_test/naive_infinite_scroll_spec.js');
config.exclude.push('dist/js/cjs/benchmarks_external/e2e_test/naive_infinite_scroll_perf.js');
// TODO: remove once https://github.com/angular/angular/issues/3757 is resolved
config.exclude.push('dist/js/cjs/benchmarks_external/e2e_test/compiler_perf.js');
config.exclude.push('dist/js/cjs/benchmarks_external/e2e_test/naive_infinite_scroll.js');
config.exclude.push('dist/js/cjs/benchmarks_external/e2e_test/tree.js');

data.createBenchpressRunner({ lang: 'js' });