Skip to content

Revert "fix(router): pass correct component to canDeactivate checks when using two or more sibling router-outlets (#36302)"#36697

Closed
matsko wants to merge 1 commit into
angular:masterfrom
matsko:revert_router_pr
Closed

Revert "fix(router): pass correct component to canDeactivate checks when using two or more sibling router-outlets (#36302)"#36697
matsko wants to merge 1 commit into
angular:masterfrom
matsko:revert_router_pr

Conversation

@matsko

@matsko matsko commented Apr 17, 2020

Copy link
Copy Markdown
Contributor

This reverts commit 80e6c07.

@matsko matsko added the target: patch This PR is targeted for the next patch release label Apr 17, 2020
@pullapprove pullapprove Bot requested a review from atscott April 17, 2020 21:09
…hen using two or more sibling router-outlets (angular#36302)"

This reverts commit 80e6c07.
@matsko matsko force-pushed the revert_router_pr branch from 3847422 to 78560a3 Compare April 17, 2020 21:15
@atscott

atscott commented Apr 17, 2020

Copy link
Copy Markdown
Contributor

Reverting in response to failure in g3: b/154150895

@ngbot ngbot Bot added this to the needsTriage milestone Apr 17, 2020
@atscott

atscott commented Apr 17, 2020

Copy link
Copy Markdown
Contributor

Presubmit - failures appear to be flakes/pre-existing

@matsko matsko added the action: merge The PR is ready for merge by the caretaker label Apr 20, 2020
@matsko matsko closed this in b5e92b9 Apr 20, 2020
matsko added a commit that referenced this pull request Apr 20, 2020
…hen using two or more sibling router-outlets (#36302)" (#36697)

This reverts commit 80e6c07.

PR Close #36697
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators May 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: router cla: yes target: patch This PR is targeted for the next patch release type: bug/fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants