Skip to content

feat(platform-browser) add LinkDefinition and Link service #34606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
d-koppenhagen wants to merge 10 commits into from
Closed

feat(platform-browser) add LinkDefinition and Link service #34606

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
9c69fe3
feat(platform-browser): implemented LinkDefinition and Link Service
d-koppenhagen Jan 1, 2020
c7aab70
style(platform-browser): format code
d-koppenhagen Jan 1, 2020
57731e6
style(platform-browser): reformat code and tests
d-koppenhagen Jan 1, 2020
ff7a2d0
test(platform-browser): fix tests for `Link` service
d-koppenhagen Jan 1, 2020
c22c674
fix(platform-browser): fix `_parseSelector` implementation
d-koppenhagen Jan 1, 2020
48984cf
test(platform-browser): replace 'meta' with 'link' in test
d-koppenhagen Jan 1, 2020
4400de4
refactor(platform-browser): update default LinkDefinition props
d-koppenhagen Jan 1, 2020
5c3e11e
fix(platform-browser): add missing Link and LinkDefinition to .d.ts
d-koppenhagen Jan 15, 2020
55fe8e3
fix(platform-browser): remove .angulardoc.json file
d-koppenhagen Jan 15, 2020
ac43446
fix: accept public api change
d-koppenhagen Feb 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix: accept public api change 
...by running `yarn bazel run //tools/public_api_guard:platform-browser_api.accept`
  • Loading branch information
@d-koppenhagen
d-koppenhagen committed Feb 28, 2020
commit ac43446418f6907cfcac0287e8aa746402ca1e7c
23 changes: 9 additions & 14 deletions tools/public_api_guard/platform-browser/platform-browser.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,36 +63,29 @@ export declare type HammerLoader = () => Promise<void>;
export declare class HammerModule {
}

export declare function makeStateKey<T = void>(key: string): StateKey<T>;

export declare class Link {
constructor(_doc: any);
addLink(tag: LinkDefinition, forceCreation?: boolean): HTMLLinkElement | null;
addLinks(tags: LinkDefinition[], forceCreation?: boolean): HTMLLinkElement[];
addLink(link: LinkDefinition, forceCreation?: boolean): HTMLLinkElement | null;
addLinks(links: LinkDefinition[], forceCreation?: boolean): HTMLLinkElement[];
getLink(attrSelector: string): HTMLLinkElement | null;
getLinks(attrSelector: string): HTMLLinkElement[];
removeLink(attrSelector: string): void;
removeLinkElement(meta: HTMLLinkElement): void;
updateLink(tag: LinkDefinition, selector?: string): HTMLLinkElement | null;
removeLinkElement(link: HTMLLinkElement): void;
updateLink(link: LinkDefinition, selector?: string): HTMLLinkElement | null;
}

export declare type LinkDefinition = {
as?: string;
crossorigin?: "anonymous" | "use-credentials";
crossorigin?: 'anonymous' | 'use-credentials';
disabled?: boolean;
href?: string;
hreflang?: string;
importance?: "auto" | "high" | "low";
importance?: 'auto' | 'high' | 'low';
integrity?: string;
media?: string;
methods?: string;
prefetch?: string;
referrerpolicy?:
| "no-referrer"
| "no-referrer-when-downgrade"
| "origin"
| "origin-when-cross-origin"
| "unsafe-url";
referrerpolicy?: 'no-referrer' | 'no-referrer-when-downgrade' | 'origin' | 'origin-when-cross-origin' | 'unsafe-url';
rel?: string;
sizes?: string;
target?: string;
Expand All @@ -102,6 +95,8 @@ export declare type LinkDefinition = {
[prop: string]: string;
};

export declare function makeStateKey<T = void>(key: string): StateKey<T>;

export declare class Meta {
constructor(_doc: any);
addTag(tag: MetaDefinition, forceCreation?: boolean): HTMLMetaElement | null;
Expand Down