ci: use more descriptive names for published build artifacts#33957
Closed
gkalpak wants to merge 1 commit into
Closed
ci: use more descriptive names for published build artifacts#33957gkalpak wants to merge 1 commit into
gkalpak wants to merge 1 commit into
Conversation
In efbbae5, the `publish_packages_as_artifacts` CircleCI job was created to publish the build artifacts of PR builds on CI. In a8f4f14, its scope was expanded to also publish build artifacts on non-PR builds. The published artifacts names are constructed based on the PR number (e.g. include `-pr12345-`), so on non-PR builds the names do not reflect the source branch (instead, they include `-prfalse-`). This commit fixes this by using the current branch name. For example, artifact names for the `master` or `9.0.x` branch will include `-master-` and `-9.0.x-` respectively (instead of `-prfalse-`). (NOTE: For PRs, where branch name is `pull/12345`, the branch name is transformed to `pr12345`.)
filipesilva
approved these changes
Nov 21, 2019
Member
Author
|
merge-assistance: The integration_test failure is unrelated. (Will be fixed by #33955.) |
devversion
approved these changes
Nov 21, 2019
Contributor
|
removing the merge-assistance label, as the caretaker can't merge PRs when CI is failing. @gkalpak is right the issue has been fixed upstream, but the caretaker can't know this for sure. rebasing the PR or restarting the CI (the entire workflow, not just failed job - this causes an automatic rebase on CI), should green up this PR |
matsko
pushed a commit
that referenced
this pull request
Nov 22, 2019
In efbbae5, the `publish_packages_as_artifacts` CircleCI job was created to publish the build artifacts of PR builds on CI. In a8f4f14, its scope was expanded to also publish build artifacts on non-PR builds. The published artifacts names are constructed based on the PR number (e.g. include `-pr12345-`), so on non-PR builds the names do not reflect the source branch (instead, they include `-prfalse-`). This commit fixes this by using the current branch name. For example, artifact names for the `master` or `9.0.x` branch will include `-master-` and `-9.0.x-` respectively (instead of `-prfalse-`). (NOTE: For PRs, where branch name is `pull/12345`, the branch name is transformed to `pr12345`.) PR Close #33957
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In efbbae5, the
publish_packages_as_artifactsCircleCI job was created to publish the build artifacts of PR builds on CI. In a8f4f14, its scope was expanded to also publish build artifacts on non-PR builds.The published artifacts names are constructed based on the PR number (e.g. include
-pr12345-), so on non-PR builds the names do not reflect the source branch (instead, they include-prfalse-).This commit fixes this by using the current branch name. For example, artifact names for the
masteror9.0.xbranch will include-master-and-9.0.x-respectively (instead of-prfalse-).(NOTE: For PRs, where branch name is
pull/12345, the branch name is transformed topr12345.)