Skip to content

WIP: Dart test package#3135

Closed
kevmoo wants to merge 12 commits into
angular:masterfrom
kevmoo:test-lib-package-2
Closed

WIP: Dart test package#3135
kevmoo wants to merge 12 commits into
angular:masterfrom
kevmoo:test-lib-package-2

Conversation

@kevmoo
Copy link
Copy Markdown
Contributor

@kevmoo kevmoo commented Jul 17, 2015

CC @juliemr

We're assuming #3132 lands

Review on Reviewable

@googlebot
Copy link
Copy Markdown

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

@juliemr
Copy link
Copy Markdown
Member

juliemr commented Jul 18, 2015

I've added to this with some helper files, which I think make the tests look a lot cleaner. See https://github.com/juliemr/angular/tree/test-lib-package-3/modules_dart/angular2_test

I could use feedback on what else would be helpful, and whether you like the looks of dart_test_with_lib better than the plain old dart_test.

@kevmoo kevmoo closed this Jul 20, 2015
@kevmoo kevmoo deleted the test-lib-package-2 branch July 20, 2015 20:44
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants