Skip to content

docs: add alexeagle to @angular/fw-global-approvers#29287

Closed
alexeagle wants to merge 1 commit into
angular:masterfrom
alexeagle:owners
Closed

docs: add alexeagle to @angular/fw-global-approvers#29287
alexeagle wants to merge 1 commit into
angular:masterfrom
alexeagle:owners

Conversation

@alexeagle
Copy link
Copy Markdown
Contributor

This is for large-scale refactorings

This is for large-scale refactorings
@alexeagle alexeagle requested a review from IgorMinar March 13, 2019 21:02
@mhevery mhevery added the area: build & ci Related the build and CI infrastructure of the project label Mar 19, 2019
@ngbot ngbot Bot added this to the needsTriage milestone Mar 19, 2019
@mhevery mhevery added action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note labels Mar 19, 2019
@ngbot
Copy link
Copy Markdown

ngbot Bot commented Mar 19, 2019

I see that you just added the PR action: merge label, but the following checks are still failing:
    failure status "ci/angular: size" is failing
    failure status "ci/circleci: aio_preview" is failing
    failure status "ci/circleci: build-ivy-npm-packages" is failing
    failure status "ci/circleci: integration_test" is failing
    failure status "ci/circleci: test" is failing
    failure status "ci/circleci: test_aio" is failing
    failure status "ci/circleci: test_aio_local" is failing
    failure status "ci/circleci: test_docs_examples" is failing
    failure status "ci/circleci: test_ivy_aot" is failing
    pending missing required labels: PR target: *
    pending missing required status "ci/circleci: publish_snapshot"
    pending 1 pending code review

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@mhevery
Copy link
Copy Markdown
Contributor

mhevery commented Mar 19, 2019

Caretaker, the failures are bogus.

@matsko matsko added the target: patch This PR is targeted for the next patch release label Mar 20, 2019
@matsko matsko closed this in ddfdf3c Mar 20, 2019
matsko pushed a commit that referenced this pull request Mar 20, 2019
This is for large-scale refactorings

PR Close #29287
wKoza pushed a commit to wKoza/angular that referenced this pull request Apr 17, 2019
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project cla: yes merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants