refactor(ivy): remove LNode.tNode#25958
Closed
kara wants to merge 1 commit into
Closed
Conversation
kara
commented
Sep 14, 2018
Contributor
Author
There was a problem hiding this comment.
This is brought in by createLNode and also brings in 3 or 4 other small functions. I think we will be able to remove them as soon as we do the injector refactor.
Some of the other added fns in here are okay because I've broken existing code up into smaller functions to share more code.
|
You can preview e9be4c9 at https://pr25958-e9be4c9.ngbuilds.io/. |
mhevery
approved these changes
Sep 14, 2018
|
You can preview 08f835c at https://pr25958-08f835c.ngbuilds.io/. |
Contributor
Author
JoostK
reviewed
Sep 14, 2018
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes
LNode.tNode.Notes:
TNodeargs instead ofLNodeargs where possible, adding as an additional argument whereLNodeswould be difficult to look up.getTNode(index)helper that allows lookup via index inTView.data.LViewData[HOST_NODE]now storesTNodeinstances instead ofLNodeinstances. There is a newgetHostElementNode()helper innode_manipulation.tsto get component hostLNodeswhere necessary.createRootComponent,getHighestElementContainer,getContainerRenderParent