feat(ivy): add `ngcc` ivy switch by mhevery · Pull Request #25238 · angular/angular

mhevery · 2018-08-01T04:31:11Z

feat(ivy): add ngcc ivy switch

Provides a runtime and compile time switch for ivy including
ApplicationRef.bootstrapModule.

This is done by naming the symbols such that ngcc (angular
Compatibility compiler) can rename symbols in such a way that running
ngcc command will switch the @angular/core module from legacy to
ivy mode.

This is done as follows:

const someToken__PRE_NGCC__ = ‘legacy mode’;
const someToken__POST_NGCC__ = ‘ivy mode’;

export someSymbol = someToken__PRE_NGCC__;

The ngcc will search for any token which ends with __PRE_NGCC__
and replace it with __POST_NGCC__. This allows the @angular/core
package to be rewritten to ivy mode post ngcc execution.

IgorMinar

This seems to be heading in the right direction, but it appears incomplete and as I commented I think we can do this without ngcc rewriting stuff.

I left a bunch of notes. Please respond inline. thanks!

IgorMinar · 2018-08-03T00:08:17Z

should this flag also get modified when you turn on the mode?

IgorMinar · 2018-08-03T00:11:45Z

who calls this? the developer before the bootstrap?

IgorMinar · 2018-08-03T00:12:56Z

I don't see these arrays being filled anywhere. is that left as todo? I assume the decorators would do this. right?

IgorMinar · 2018-08-03T00:17:09Z

Why do you need ngcc to rename anything? if the decorators add stuff to the queue and the code just below this line does the compilation then nothing alive in the system refers to the ivy compiler unless you call enableIvyJitCompiler.

Unless I'm looking at this wrong, if you call the method from your app, you get ivy, otherwise ivy is dead code eliminated.

discussed offline

IgorMinar · 2018-08-03T00:18:50Z

how will the queues get drained for lazy loaded code?

IgorMinar · 2018-08-03T00:22:36Z

what's the relationship between enableIvyBootstrap and enableIvyJitCompiler? when would I use which?

IgorMinar

LGTM but please note that CI is currently very unhappy.

mary-poppins · 2018-08-15T21:29:18Z

You can preview a206f5a at https://pr25238-a206f5a.ngbuilds.io/.

IgorMinar · 2018-08-15T21:37:59Z

@mhevery can you please update the commit message? it still mentions the api that we decided not to expose.

Provides a runtime and compile time switch for ivy including `ApplicationRef.bootstrapModule`. This is done by naming the symbols such that `ngcc` (angular Compatibility compiler) can rename symbols in such a way that running `ngcc` command will switch the `@angular/core` module from `legacy` to `ivy` mode. This is done as follows: ``` const someToken__PRE_NGCC__ = ‘legacy mode’; const someToken__POST_NGCC__ = ‘ivy mode’; export someSymbol = someToken__PRE_NGCC__; ``` The `ngcc` will search for any token which ends with `__PRE_NGCC__` and replace it with `__POST_NGCC__`. This allows the `@angular/core` package to be rewritten to ivy mode post `ngcc` execution.

mhevery · 2018-08-15T23:29:26Z

http://test/OCL:208886029:BASE:208903764:1534375685903:825ea3b6

mary-poppins · 2018-08-15T23:35:34Z

You can preview c8e9145 at https://pr25238-c8e9145.ngbuilds.io/.

mary-poppins · 2018-08-15T23:44:00Z

You can preview ada15d0 at https://pr25238-ada15d0.ngbuilds.io/.

mary-poppins · 2018-08-16T04:20:22Z

You can preview 8204725 at https://pr25238-8204725.ngbuilds.io/.

mary-poppins · 2018-08-16T05:32:19Z

You can preview 265573a at https://pr25238-265573a.ngbuilds.io/.

This method will be used to find all the places where the "ivy switch" will occur. See angular#25238

This supports the "ngcc ivy switch" specified in angular#25238.

…#25534) This method will be used to find all the places where the "ivy switch" will occur. See #25238 PR Close #25534

This supports the "ngcc ivy switch" specified in #25238. PR Close #25534

angular-automatic-lock-bot · 2019-09-13T23:22:55Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

mhevery added state: WIP comp: ivy labels Aug 1, 2018

mhevery requested review from IgorMinar and alxhub August 1, 2018 04:31

googlebot added the cla: yes label Aug 1, 2018

mhevery force-pushed the enableIvy branch from 6d311e7 to 00110b1 Compare August 1, 2018 04:34

IgorMinar reviewed Aug 3, 2018

View reviewed changes

mhevery force-pushed the enableIvy branch from 00110b1 to db7f263 Compare August 9, 2018 22:10

mhevery changed the title ~~feat(ivy): add enableIvyBootstrap() and enableIvyJitCompiler() switch~~ feat(ivy): add ngcc ivy switch Aug 9, 2018

IgorMinar approved these changes Aug 13, 2018

View reviewed changes

mhevery force-pushed the enableIvy branch from db7f263 to a206f5a Compare August 15, 2018 21:16

mhevery added target: major This PR is targeted for the next major release and removed state: WIP labels Aug 15, 2018

IgorMinar added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Aug 15, 2018

mhevery force-pushed the enableIvy branch from a206f5a to c8e9145 Compare August 15, 2018 23:27

mhevery removed the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Aug 15, 2018

fixup! feat(ivy): add ngcc ivy switch

ada15d0

fixup! feat(ivy): add ngcc ivy switch

8204725

fixup! feat(ivy): add ngcc ivy switch

8840fb1

mhevery force-pushed the enableIvy branch from 265573a to 8840fb1 Compare August 16, 2018 14:57

fixup! feat(ivy): add ngcc ivy switch

ed87ef9

fixup! feat(ivy): add ngcc ivy switch

fd9ff91

mhevery added the action: merge The PR is ready for merge by the caretaker label Aug 16, 2018

mhevery removed the request for review from alxhub August 16, 2018 20:39

jasonaden closed this in 503905c Aug 16, 2018

petebacondarwin mentioned this pull request Aug 17, 2018

ngcc: implement ivy switch rendering #25534

Closed

petebacondarwin added a commit to petebacondarwin/angular that referenced this pull request Aug 28, 2018

feat(ivy): implement NgccReflectionHost.getSwitchableDeclarations()

a5173e8

This method will be used to find all the places where the "ivy switch" will occur. See angular#25238

petebacondarwin added a commit to petebacondarwin/angular that referenced this pull request Aug 28, 2018

feat(ivy): implement Renderer.getSwitchableDeclarations

9a0c285

This supports the "ngcc ivy switch" specified in angular#25238.

mhevery pushed a commit that referenced this pull request Aug 31, 2018

feat(ivy): implement NgccReflectionHost.getSwitchableDeclarations() (…

6f168b7

…#25534) This method will be used to find all the places where the "ivy switch" will occur. See #25238 PR Close #25534

mhevery pushed a commit that referenced this pull request Aug 31, 2018

feat(ivy): implement Renderer.getSwitchableDeclarations (#25534)

26cd9f5

This supports the "ngcc ivy switch" specified in #25238. PR Close #25534

angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 13, 2019

Conversation

mhevery commented Aug 1, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

IgorMinar left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

IgorMinar left a comment

Choose a reason for hiding this comment

Uh oh!

mary-poppins commented Aug 15, 2018

Uh oh!

IgorMinar commented Aug 15, 2018

Uh oh!

mhevery commented Aug 15, 2018

Uh oh!

mary-poppins commented Aug 15, 2018

Uh oh!

mary-poppins commented Aug 15, 2018

Uh oh!

mary-poppins commented Aug 16, 2018

Uh oh!

mary-poppins commented Aug 16, 2018

Uh oh!

angular-automatic-lock-bot Bot commented Sep 13, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

mhevery commented Aug 1, 2018 •

edited

Loading