build(bazel): entry point file couldn't be resolved [ts-api-guardian]#25052
Closed
devversion wants to merge 1 commit into
Closed
build(bazel): entry point file couldn't be resolved [ts-api-guardian]#25052devversion wants to merge 1 commit into
devversion wants to merge 1 commit into
Conversation
* When using `ts-api-guardian` on Windows, the input file can't be found due to wrong normalized path delimiters.
gkalpak
reviewed
Jul 23, 2018
| const entrypoint = path.normalize(fileName); | ||
| // Since the entry point will be compared with the source files from the TypeScript program, | ||
| // the path needs to be normalized with forward slashes in order to work within Windows. | ||
| const entrypoint = path.normalize(fileName).replace(/\\/g, '/'); |
Member
Author
There was a problem hiding this comment.
I didn't want to introduce another dependency for something simple. Also I'd have preferred using ts.normalizePath but that's apparently internal 😄
Contributor
There was a problem hiding this comment.
I think you can use path.posix.normaize
Member
Author
There was a problem hiding this comment.
Thought that too, but unfortunately it doesn't work that way :/ (nodejs/node#12298)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ts-api-guardianon Windows, the input file can't be found due to wrong normalized path delimiters.PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
cc. @alexeagle. Wasn't sure how to indicate that this affects ts-api-guardian, so I've added it as a suffix.