Skip to content

test: add i18n to cli-hello-world integration test - #23527

Closed
ocombe wants to merge 2 commits into
angular:masterfrom
ocombe:test/cli-i18n-locales
Closed

test: add i18n to cli-hello-world integration test#23527
ocombe wants to merge 2 commits into
angular:masterfrom
ocombe:test/cli-i18n-locales

Conversation

@ocombe

@ocombe ocombe commented Apr 24, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor

Adding a test for i18n locales to the cli hello world integration test

@ocombe ocombe added area: common Issues related to APIs in the @angular/common package aio: preview target: patch This PR is targeted for the next patch release labels Apr 24, 2018
@ocombe
ocombe requested review from alexeagle and filipesilva April 24, 2018 18:38
@ocombe
ocombe force-pushed the test/cli-i18n-locales branch 4 times, most recently from 7f72883 to 1ac0a9d Compare April 25, 2018 09:06
@ocombe
ocombe force-pushed the test/cli-i18n-locales branch from 1ac0a9d to b006ec9 Compare April 25, 2018 09:33
@ocombe ocombe added action: review The PR is still awaiting reviews from at least one requested reviewer and removed aio: preview labels Apr 25, 2018
@alexeagle

alexeagle commented Apr 25, 2018

Copy link
Copy Markdown
Contributor

I think we also need an update to integration/README.md which currently says that we upgrade the CLI by throwing away this app and generating it fresh. We had no local modifications previously so there was no reason to be careful about upgrading.
I think the right text there now should read that we use ng update command to keep this example app up-to-date as CLI changes things?

@ocombe

ocombe commented Apr 25, 2018

Copy link
Copy Markdown
Contributor Author

There's a few stuff that needs to be updated for sure, run_test.sh tests for "hello_world__render3__cli" which doesn't exist anymore afaik. Same thing for _payload-limits.json with "hello_world__render3__rollup" and "hello_world__render3__cli" (unless they are generated somehow?).
But it should probably a different PR?

@alexeagle

alexeagle commented Apr 25, 2018 via email

Copy link
Copy Markdown
Contributor

alexeagle
alexeagle approved these changes Apr 25, 2018
View reviewed changes

@alexeagle alexeagle left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would be nice to update that README too

Comment thread integration/cli-hello-world/package.json
"devDependencies": {
"@angular-devkit/build-angular": "~0.5.0",
"@angular/cli": "^6.0.0-rc.0",
"@angular/cli": "^6.0.0-rc.5",

@alexeagle alexeagle Apr 25, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm we need some plan for doing this upgrade more frequently...
not in this PR :)

@ocombe ocombe Apr 25, 2018

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the update is necessary in this PR because the fix is in rc5

Comment thread integration/cli-hello-world/src/app/app.module.ts

import { AppComponent } from './app.component';

registerLocaleData(localeFr);

@alexeagle alexeagle Apr 25, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

include a comment pointing to the issue so we know why this is here - otherwise seems unneeded

@ocombe
ocombe force-pushed the test/cli-i18n-locales branch from 5fe3a3e to 121bd86 Compare April 26, 2018 08:27
@alexeagle alexeagle added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Apr 26, 2018
@IgorMinar IgorMinar closed this in 8062f7d Apr 27, 2018
IgorMinar pushed a commit that referenced this pull request Apr 27, 2018
@ocombe @IgorMinar
test: add i18n to cli-hello-world integration test (#23527)
693a7ba 
PR Close #23527
IgorMinar pushed a commit that referenced this pull request Apr 27, 2018
@ocombe @IgorMinar
test: add i18n to cli-hello-world integration test (#23527)
3e92b22 
PR Close #23527
@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented Sep 13, 2019

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers
@alexeagle alexeagle alexeagle approved these changes
@filipesilva filipesilva filipesilva approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@alexeagle alexeagle

Labels

action: merge The PR is ready for merge by the caretaker area: common Issues related to APIs in the @angular/common package cla: yes target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ocombe @alexeagle @filipesilva @googlebot