fix(ShadowCss): keyframes tests failing in Safari#2283
Closed
marclaval wants to merge 1 commit into
Closed
Conversation
Contributor
There was a problem hiding this comment.
Do we really want to add this to the adapter ?
Contributor
Author
There was a problem hiding this comment.
It seems to be the proper place as the implementations are different in Node.js vs real browsers.
It could be done directly in the test or somewhere in test_lib if we don't want to grow the adapter too much, somethig like:
if (isPresent(this.defaultDoc().body.style) && isPresent(this.defaultDoc().body.style.animationName)) {
//execute test
}
Contributor
There was a problem hiding this comment.
I was also thinking about tests - probably makes sense as this should probably not be used anywhere else
8ec3f80 to
a94d8d6
Compare
Contributor
|
LGTM |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 2 tests were broken in both desktop and mobile Safari.
With this PR, these 2 browsers are back to green.