Update i18n locale data extraction script#21626
Closed
ocombe wants to merge 2 commits intoangular:masterfrom
Closed
Update i18n locale data extraction script#21626ocombe wants to merge 2 commits intoangular:masterfrom
ocombe wants to merge 2 commits intoangular:masterfrom
Conversation
47d6bf1 to
dfe26ed
Compare
|
You can preview dfe26ed at https://pr21626-dfe26ed.ngbuilds.io/. |
dfe26ed to
97312d8
Compare
|
You can preview 97312d8 at https://pr21626-97312d8.ngbuilds.io/. |
vicb
approved these changes
Jan 18, 2018
Contributor
|
While the TS 2.6 commit (second one) is not strictly required for the patch branch, it's better to keep generated files in sync between master and patch. |
Contributor
|
running g3sync presubmit http://test/OCL:182567375:BASE:182567631:1516391751302:a8e6c969 |
mhevery
pushed a commit
to mhevery/angular
that referenced
this pull request
Jan 25, 2018
mhevery
pushed a commit
to mhevery/angular
that referenced
this pull request
Jan 25, 2018
…TS 2.6 (angular#21626) Fixes angular#21608 PR Close angular#21626
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
What is the current behavior?
We have multiple issues with the extraction script for CLDR data:
inspectfunction fromutilto print missing values from arrays (util: change sparse arrays inspection format nodejs/node#11576) resulting in corrupted data filesinspectmethodIssue Number: #21608
What is the new behavior?
I've replaced the
inspectfunction by a modifiedJSON5.stringifymethod which fixed all of the issues, and I've extracted the plural function as requested. You can find the new LTR/RTL characters in languages such as arabic (ar.ts) or hebrew (he.ts)I pushed two different commits since I did two different updates.
Does this PR introduce a breaking change?