Skip to content

refactor(core): split up interface files in render3 - #21433

Closed
kara wants to merge 1 commit into
angular:masterfrom
kara:split-up
Closed

refactor(core): split up interface files in render3#21433
kara wants to merge 1 commit into
angular:masterfrom
kara:split-up

Conversation

@kara

@kara kara commented Jan 10, 2018

Copy link
Copy Markdown
Contributor

This PR splits up our gigantic interfaces file in render3 into several smaller files in an "interfaces" folder, so it's easier to find what you need.

Note: Review only last commit (waiting on #21403).

New files:

  • interfaces/renderer.ts: R* (same as today)
  • interfaces/node.ts: *Node
  • interfaces/view.ts: *View
  • interfaces/container.ts: *Container
  • interfaces/projection.ts: *Projection
  • interfaces/query.ts: *Query
  • interfaces/injector.ts: *Injector

@kara
kara requested a review from mhevery January 10, 2018 02:58
@kara kara added action: review The PR is still awaiting reviews from at least one requested reviewer area: core Issues related to the framework runtime target: major This PR is targeted for the next major release labels Jan 10, 2018
@mary-poppins

mary-poppins commented Jan 10, 2018

Copy link
Copy Markdown

You can preview 7869d66 at https://pr21433-7869d66.ngbuilds.io/.

@kara kara added comp: ivy and removed area: core Issues related to the framework runtime labels Jan 10, 2018
@mary-poppins

mary-poppins commented Jan 10, 2018

Copy link
Copy Markdown

You can preview 23bff34 at https://pr21433-23bff34.ngbuilds.io/.

@kara kara added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jan 10, 2018
@mary-poppins

mary-poppins commented Jan 10, 2018

Copy link
Copy Markdown

You can preview 2ca472c at https://pr21433-2ca472c.ngbuilds.io/.

@mary-poppins

mary-poppins commented Jan 10, 2018

Copy link
Copy Markdown

You can preview d5e8297 at https://pr21433-d5e8297.ngbuilds.io/.

@alexeagle alexeagle added target: patch This PR is targeted for the next patch release and removed target: major This PR is targeted for the next major release labels Jan 11, 2018
@alexeagle alexeagle closed this in 6be9c04 Jan 11, 2018
@alexeagle alexeagle added target: major This PR is targeted for the next major release and removed target: patch This PR is targeted for the next patch release labels Jan 11, 2018
kara added a commit to kara/angular that referenced this pull request Jan 11, 2018
@kara
revert: refactor(core): split up interface files in render3 (angular#…
05dce31 
…21433)

This reverts commit 6be9c04.
@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented Sep 13, 2019

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@mhevery mhevery mhevery approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker cla: yes target: major This PR is targeted for the next major release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@kara @mary-poppins @mhevery @alexeagle @googlebot